Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 1473733007: [turbofan] Checking monotonicity of representation inference outputs and inputs. (Closed)

Created:
5 years ago by Jarin
Modified:
5 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Checking monotonicity of representation inference outputs and inputs. Monotonicity is not required at the current setup, where we do backward pass through the graph. However, for bidirectinal analysis, we'd better be sure that all the input/use information is monotone. The checker here is quite strict - it requires monotonicity in each of: use representations, use truncation, output representation and output type. In future, we can lower the requirements and use lexicographic ordering (e.g., on use truncation and representation). Committed: https://crrev.com/ebed36ee4ad6dc7c3794d527d046588f3cff75f7 Cr-Commit-Position: refs/heads/master@{#32392}

Patch Set 1 #

Patch Set 2 : Tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -20 lines) Patch
M src/compiler/representation-change.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 13 chunks +138 lines, -20 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Jarin
Could you take a look, please?
5 years ago (2015-11-30 07:56:11 UTC) #4
Benedikt Meurer
Nice. LGTM.
5 years ago (2015-11-30 08:34:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1473733007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1473733007/20001
5 years ago (2015-11-30 09:15:38 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-30 09:22:25 UTC) #9
commit-bot: I haz the power
5 years ago (2015-11-30 09:22:47 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ebed36ee4ad6dc7c3794d527d046588f3cff75f7
Cr-Commit-Position: refs/heads/master@{#32392}

Powered by Google App Engine
This is Rietveld 408576698