Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1473733005: Revert of [Discardable Shared Memory] Adding Windows support. (Closed)

Created:
5 years ago by nednguyen
Modified:
5 years ago
CC:
chromium-reviews, gavinp+memory_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Discardable Shared Memory] Adding Windows support. (patchset #5 id:80001 of https://codereview.chromium.org/1427163003/ ) Reason for revert: Speculative revert: this may cause regression to smoothness.tough_canvas_cases BUG=555225 Original issue's description: > [Discardable Shared Memory] Adding Windows support. > > 1) Purge(): Now doing VirtualFree MEM_DECOMMIT back to XP during a purge. > This releases the physical storage, either in memory or in the paging file on disk. > Pages remain RESERVED. NOTE: this is the best that can be done immediately > from the browser, until the child/renderer notices the purge and releases its own > handles. > > 2) Lock/Unlock() pinning: For >= Win8, we have access to MEM_RESET_UNDO support. > On Unlock(), we now MEM_RESET. On Lock(), we MEM_RESET_UNDO. > This mimics the existing Ashmem support on Android. > (See bug ticket for why OfferVirtualMemory/ReclaimVirtualMemory is not being used.) > > BUG=180334 > R=reveman@chromium.org,jschuh@chromium.org > > Committed: https://crrev.com/498c30ec10c16ba90cd425836c5a92ac0d685c36 > Cr-Commit-Position: refs/heads/master@{#358466} TBR=reveman@chromium.org,brucedawson@chromium.org,jschuh@chromium.org,danakj@chromium.org,thestig@chromium.org,pennymac@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=180334 Committed: https://crrev.com/d4bd2aafb9eb736fa1cf3844cb389c30d91aa7db Cr-Commit-Position: refs/heads/master@{#361748}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -40 lines) Patch
M base/memory/discardable_shared_memory.cc View 6 chunks +0 lines, -40 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
nednguyen
Created Revert of [Discardable Shared Memory] Adding Windows support.
5 years ago (2015-11-25 22:13:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1473733005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1473733005/1
5 years ago (2015-11-25 22:14:26 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 22:16:43 UTC) #4
commit-bot: I haz the power
5 years ago (2015-11-25 22:17:49 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d4bd2aafb9eb736fa1cf3844cb389c30d91aa7db
Cr-Commit-Position: refs/heads/master@{#361748}

Powered by Google App Engine
This is Rietveld 408576698