Issue 147373005: Move webkit/common/webpreferences to content/public/common/

Issue 147373005: Move webkit/common/webpreferences to content/public/common/ (Closed)

Created:
6 years, 10 months ago by pilgrim_google

Modified:
6 years, 10 months ago

Reviewers:
darin (slow to review), jam

CC:
chromium-reviews, extensions-reviews_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, chromium-apps-reviews_chromium.org, android-webview-reviews_chromium.org, jochen+watch_chromium.org, miu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move webkit/common/webpreferences to content/public/common/ BUG=338338

Patch Set 1 #

Total comments: 3

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+101 lines, -491 lines)			Patch
M	android_webview/browser/aw_content_browser_client.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	android_webview/native/aw_settings.cc	View	2 chunks	+7 lines, -7 lines	0 comments	Download
M	android_webview/renderer/print_web_view_helper.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/android/voice_search_tab_helper.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chrome_content_browser_client.cc	View	3 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_webkit_preferences.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/gpu_browsertest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/prefs/chrome_pref_service_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/printing/print_dialog_cloud.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/prefs/prefs_tab_helper.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/renderer/printing/print_web_view_helper.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	components/plugins/renderer/webview_plugin.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	content/browser/android/content_settings.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/gpu/gpu_data_manager_impl_private.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	content/browser/renderer_host/render_view_host_delegate.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/renderer_host/render_widget_host_impl.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	content/browser/web_contents/web_contents_impl.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	content/child/browser_font_resource_trusted.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/content_common.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/public/common/common_param_traits_macros.h	View	3 chunks	+2 lines, -2 lines	0 comments	Download
A +	content/public/common/webpreferences.h	View	6 chunks	+19 lines, -19 lines	2 comments	Download
A +	content/public/common/webpreferences.cc	View	3 chunks	+21 lines, -21 lines	0 comments	Download
M	content/renderer/pepper/ppb_graphics_3d_impl.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	content/renderer/render_view_browsertest_mac.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/render_view_impl.h	View	2 chunks	+1 line, -1 line	0 comments	Download
M	content/renderer/web_preferences.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	content/shell/browser/shell_content_browser_client.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	content/shell/browser/webkit_test_controller.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/shell/common/webkit_test_helpers.cc	View	4 chunks	+12 lines, -12 lines	0 comments	Download
M	content/shell/renderer/webkit_test_runner.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	content/test/test_render_view_host.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/test/test_web_contents.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/shared_impl/DEPS	View	1 chunk	+1 line, -1 line	1 comment	Download
M	ppapi/shared_impl/ppapi_preferences.h	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	webkit/common/webkit_common.gyp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	webkit/common/webpreferences.h	View	1 chunk	+0 lines, -200 lines	0 comments	Download
D	webkit/common/webpreferences.cc	View	1 chunk	+0 lines, -190 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jam

6 years, 10 months ago (2014-01-30 00:08:45 UTC) #3

https://codereview.chromium.org/147373005/diff/1/content/public/common/webpre...
File content/public/common/webpreferences.h (right):

https://codereview.chromium.org/147373005/diff/1/content/public/common/webpre...
content/public/common/webpreferences.h:37: enum EditingBehavior {
per content api, each struct/class/enum would go in its own class
(http://www.chromium.org/developers/content-module/content-api)

I looked at the change that added this, looks like a boolean can suffice instead
of another enum: use_windows_layout

https://codereview.chromium.org/147373005/diff/1/content/public/common/webpre...
content/public/common/webpreferences.h:52: struct CONTENT_EXPORT WebPreferences
{
everything in src/content should be in the content namespace

https://codereview.chromium.org/147373005/diff/1/ppapi/shared_impl/DEPS
File ppapi/shared_impl/DEPS (right):

https://codereview.chromium.org/147373005/diff/1/ppapi/shared_impl/DEPS#newcode7
ppapi/shared_impl/DEPS:7: "+content/public/common/webpreferences.h",
src/ppapi is lower than content in the dependency stack, so it shouldn't include
it. looks like the constructor of ppapi::Preferences which takes a
WebPreferences is only called in src/content/renderer, so a
ppapi_preferences_builder file can be added somewhere under src/content/renderer
which does this conversion

Expand Messages | Collapse Messages