Force landscape rotation of full-screen HTML5 video on Android

Force landscape rotation of full-screen HTML5 video on Android

Rotate to landscape mode on entering full screen HTML5 video playback. Rotate
back when leaving full screen.

BUG=326572

[philipj_slow, 2014-01-29 13:02:50]

Videos which are not themselves landscape exist, for example videos recorded on
a cellphone in portrait mode. For this to work really well, the dimensions of
the video and the dimensions of the screen must both be taken into
consideration.

https://codereview.chromium.org/147373004/diff/1/content/public/android/java/...
File
content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java
(right):

https://codereview.chromium.org/147373004/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java:171:
a.setRequestedOrientation(ActivityInfo.SCREEN_ORIENTATION_LANDSCAPE);
SCREEN_ORIENTATION_USER_LANDSCAPE is probably the post appropriate mode for
landscape videos, since it allows the user to pick either of the two landscape
orientations if they don't have the rotate lock on.

https://codereview.chromium.org/147373004/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java:404:
a.setRequestedOrientation(ActivityInfo.SCREEN_ORIENTATION_PORTRAIT);
This line should be removed, it's overridden immediately.

[qinmin, 2014-01-29 16:04:44]

not lgtm.
There is no user metrics to support this feature.
User can always rotate the screen to enter landscape mode. Force landscape
roration will force user to rotate the screen, which just make him lose the
choice

[jdduke (slow), 2014-01-29 16:12:33]

On 2014/01/29 16:04:44, qinmin wrote:
> not lgtm.
> There is no user metrics to support this feature.
> User can always rotate the screen to enter landscape mode. Force landscape
> roration will force user to rotate the screen, which just make him lose the
> choice

I wouldn't say there's no support for this feature.  Is this not exactly what
the Youtube app does when you go fullscreen?

[jdduke (slow), 2014-01-29 16:15:03]

On 2014/01/29 16:12:33, jdduke wrote:
> On 2014/01/29 16:04:44, qinmin wrote:
> > not lgtm.
> > There is no user metrics to support this feature.
> > User can always rotate the screen to enter landscape mode. Force landscape
> > roration will force user to rotate the screen, which just make him lose the
> > choice
> 
> I wouldn't say there's no support for this feature.  Is this not exactly what
> the Youtube app does when you go fullscreen?

I ask this as a person that typically hates auto-rotation (I have orientation
locked on all my devices, tablet and phone).  However, the primary exception
I've found is full-screen videos, which is why I *really* like the way Youtube
will rotate to landscape for landscape-oriented videos.

[qinmin, 2014-01-29 16:20:58]

On 2014/01/29 16:12:33, jdduke wrote:
> On 2014/01/29 16:04:44, qinmin wrote:
> > not lgtm.
> > There is no user metrics to support this feature.
> > User can always rotate the screen to enter landscape mode. Force landscape
> > roration will force user to rotate the screen, which just make him lose the
> > choice
> 
> I wouldn't say there's no support for this feature.  Is this not exactly what
> the Youtube app does when you go fullscreen?

1. not all the videos are suited for landscape
2. Use case is totally different between youtube app and browser. You can watch
youtube for 2 hours without rotate your screen. But if a 5 second video requires
a user to rotate his screen back and force, is this really a good user
experience?
3. user choice. 
4. the chromium bug referenced in this change is about rotation lock, instead of
forcing rotation.

[jdduke (slow), 2014-01-29 16:31:12]

On 2014/01/29 16:20:58, qinmin wrote:
> On 2014/01/29 16:12:33, jdduke wrote:
> > On 2014/01/29 16:04:44, qinmin wrote:
> > > not lgtm.
> > > There is no user metrics to support this feature.
> > > User can always rotate the screen to enter landscape mode. Force landscape
> > > roration will force user to rotate the screen, which just make him lose
the
> > > choice
> > 
> > I wouldn't say there's no support for this feature.  Is this not exactly
what
> > the Youtube app does when you go fullscreen?
> 
> 1. not all the videos are suited for landscape

Right, that's why I said landscape-oriented videos, and only in full-screen
mode.

> 2. Use case is totally different between youtube app and browser. You can
watch
> youtube for 2 hours without rotate your screen. But if a 5 second video
requires
> a user to rotate his screen back and force, is this really a good user
> experience?

The problem there is 5-second *full-screen* videos... That's just as abrasive as
an orientation change in my mind.

> 3. user choice. 

Yeah, this is the best argument to leave the current behavior.

> 4. the chromium bug referenced in this change is about rotation lock, instead
of
> forcing rotation.

OK...

[philipj_slow, 2014-06-16 13:27:53]

Please close this review if it's not going anywhere. (Removing self as reviewer
to get it off my dashboard.)