Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1031)

Issue 1473633002: Reland of Switch V8HiddenValue from hidden values to privates (Closed)

Created:
5 years ago by jochen (gone - plz use gerrit)
Modified:
5 years ago
Reviewers:
haraken, sof, vogelheim
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Switch V8HiddenValue from hidden values to privates (patchset #1 id:1 of https://codereview.chromium.org/1466733006/ ) Reason for revert: Underlying oilpan issues were addressed. Esp. the hidden values are no longer touched in V8AbstractEventListener's dtor Original issue's description: > Revert of Switch V8HiddenValue from hidden values to privates (patchset #7 id:120001 of https://codereview.chromium.org/1416053012/ ) > > Reason for revert: > This CL broke tests in oilpan builds. > > https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Oilpan_ASAN/5177/layout-test-results/results.html > > Original issue's description: > > Switch V8HiddenValue from hidden values to privates > > > > Privates are like ES6 symbols, but are not accesible by JavaScript. > > Hidden values on the other hand will be deleted form the API soon. > > > > BUG=none > > R=haraken@chromium.org > > > > Committed: https://crrev.com/b1802c0fc28635a50e7f55e40c71e69281cc85f3 > > Cr-Commit-Position: refs/heads/master@{#360786} > > TBR=vogelheim@chromium.org,sigbjornf@opera.com,jochen@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=none > > Committed: https://crrev.com/dfb67af2fb65ecb0daec0498140ad6d7a9a0ea59 > Cr-Commit-Position: refs/heads/master@{#361016} R=vogelheim@chromium.org,sigbjornf@opera.com,haraken@chromium.org Committed: https://crrev.com/7fc3f2ba0e94feba4116f64c72b653c1554794c7 Cr-Commit-Position: refs/heads/master@{#361417}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.cpp View 1 chunk +11 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
jochen (gone - plz use gerrit)
Created Reland of Switch V8HiddenValue from hidden values to privates
5 years ago (2015-11-24 16:52:58 UTC) #1
jochen (gone - plz use gerrit)
ptal (not sending automatically to CQ)
5 years ago (2015-11-24 16:53:33 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1473633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1473633002/1
5 years ago (2015-11-24 16:55:09 UTC) #5
vogelheim
lgtm
5 years ago (2015-11-24 17:48:09 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-24 18:14:43 UTC) #8
sof
lgtm to retry
5 years ago (2015-11-24 18:26:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1473633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1473633002/1
5 years ago (2015-11-24 19:43:11 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 19:55:30 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7fc3f2ba0e94feba4116f64c72b653c1554794c7 Cr-Commit-Position: refs/heads/master@{#361417}
5 years ago (2015-11-24 19:56:22 UTC) #13
haraken
LGTM
5 years ago (2015-11-24 23:32:04 UTC) #14
sof
5 years ago (2015-11-25 06:38:09 UTC) #15
Message was sent while issue was closed.
Oilpan bots not picking up anything bad here either.

(That leaves https://codereview.chromium.org/1467493002/ , where no revert is in
order, really. )

Powered by Google App Engine
This is Rietveld 408576698