DescriptionReland of Switch V8HiddenValue from hidden values to privates (patchset #1 id:1 of https://codereview.chromium.org/1466733006/ )
Reason for revert:
Underlying oilpan issues were addressed. Esp. the hidden values are no longer touched in V8AbstractEventListener's dtor
Original issue's description:
> Revert of Switch V8HiddenValue from hidden values to privates (patchset #7 id:120001 of https://codereview.chromium.org/1416053012/ )
>
> Reason for revert:
> This CL broke tests in oilpan builds.
>
> https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Oilpan_ASAN/5177/layout-test-results/results.html
>
> Original issue's description:
> > Switch V8HiddenValue from hidden values to privates
> >
> > Privates are like ES6 symbols, but are not accesible by JavaScript.
> > Hidden values on the other hand will be deleted form the API soon.
> >
> > BUG=none
> > R=haraken@chromium.org
> >
> > Committed: https://crrev.com/b1802c0fc28635a50e7f55e40c71e69281cc85f3
> > Cr-Commit-Position: refs/heads/master@{#360786}
>
> TBR=vogelheim@chromium.org,sigbjornf@opera.com,jochen@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=none
>
> Committed: https://crrev.com/dfb67af2fb65ecb0daec0498140ad6d7a9a0ea59
> Cr-Commit-Position: refs/heads/master@{#361016}
R=vogelheim@chromium.org,sigbjornf@opera.com,haraken@chromium.org
Committed: https://crrev.com/7fc3f2ba0e94feba4116f64c72b653c1554794c7
Cr-Commit-Position: refs/heads/master@{#361417}
Patch Set 1 #
Messages
Total messages: 15 (4 generated)
|