Issue 147363007: Enable the CrossSiteIframe test for --site-per-process to catch regressions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 147363007: Enable the CrossSiteIframe test for --site-per-process to catch regressions. (Closed)

Created:
6 years, 10 months ago by Charlie Reis

Modified:
6 years, 10 months ago

Reviewers:
nasko

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Enable the CrossSiteIframe test for --site-per-process to catch regressions. Also removes an incorrect DCHECK from NavigatorImpl. BUG=99379 TEST=SitePerProcessBrowserTest.CrossSiteIframe passes. R=nasko@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250787

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -20 lines)			Patch
	M	content/browser/frame_host/navigator_impl.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	content/browser/site_per_process_browsertest.cc	View		5 chunks	+42 lines, -18 lines	0 comments	Download

Total messages: 3 (0 generated)

Charlie Reis

Nasko, here's the basic test fixes and DCHECK removal (separated from https://codereview.chromium.org/156303004/). Can you review?

6 years, 10 months ago (2014-02-12 17:44:45 UTC) #1

Charlie Reis

6 years, 10 months ago (2014-02-12 20:37:49 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r250787 (presubmit successful).