Issue 14736005: reimplement generateFontMetrics to keep all calculations in SkScalar, avoiding the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14736005: reimplement generateFontMetrics to keep all calculations in SkScalar, avoiding the (Closed)

Created:
7 years, 7 months ago by reed1

Modified:
7 years, 7 months ago

Reviewers:
bungeman-skia

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/

Visibility:
Public.

More Reviews

Description

reimplement generateFontMetrics to keep all calculations in SkScalar, avoiding the risk of over/under-flow w/ the current fixed-point intermediates. Committed: https://code.google.com/p/skia/source/detail?r=9005

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -11 lines)			Patch
	M	trunk/src/ports/SkFontHost_FreeType.cpp	View		8 chunks	+28 lines, -11 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

reed1

7 years, 7 months ago (2013-05-06 12:21:18 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 manually as r9005 (presubmit successful).

Expand Messages | Collapse Messages