Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1473593002: [turbofan] Properly recognize and optimize comparisons with the_hole. (Closed)

Created:
5 years ago by Benedikt Meurer
Modified:
5 years ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Properly recognize and optimize comparisons with the_hole. We use comparisons with the_hole to implement temporal dead zones, so we should also optimize those, as they currently turn into CompareIC calls. R=jarin@chromium.org Committed: https://crrev.com/09fb5686e69f11e9b2fea9a19f173f8e40852bfe Cr-Commit-Position: refs/heads/master@{#32198}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M src/compiler/js-typed-lowering.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M src/compiler/typer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/typer.cc View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Benedikt Meurer
Hey Jaro, Here's the_hole patch for typer and typed lowering. Please take a look. Thanks, ...
5 years ago (2015-11-24 09:21:06 UTC) #3
Jarin
lgtm
5 years ago (2015-11-24 09:49:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1473593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1473593002/1
5 years ago (2015-11-24 10:14:26 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 10:15:41 UTC) #7
commit-bot: I haz the power
5 years ago (2015-11-24 10:16:01 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/09fb5686e69f11e9b2fea9a19f173f8e40852bfe
Cr-Commit-Position: refs/heads/master@{#32198}

Powered by Google App Engine
This is Rietveld 408576698