chrome/browser/ui/webui/signin/login_ui_service.cc - Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/signin/login_ui_service.cc

Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: format Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc ('k') | chrome/browser/ui/webui/signin/login_ui_test_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/signin/login_ui_service.cc

diff --git a/chrome/browser/ui/webui/signin/login_ui_service.cc b/chrome/browser/ui/webui/signin/login_ui_service.cc

index cc1681d66027c04f8863d29436ae2f59706e142c..115396b8111fdaca59fa0a86d3bc6815e148d14f 100644

--- a/chrome/browser/ui/webui/signin/login_ui_service.cc

+++ b/chrome/browser/ui/webui/signin/login_ui_service.cc

@@ -68,7 +68,8 @@ void LoginUIService::ShowLoginPopup() {

chrome::ScopedTabbedBrowserDisplayer displayer(

profile_, chrome::GetActiveDesktop());

chrome::ShowBrowserSignin(

- displayer.browser(), signin_metrics::SOURCE_APP_LAUNCHER);

+ displayer.browser(),

+ signin_metrics::AccessPoint::ACCESS_POINT_EXTENSIONS);

#endif

}

@@ -80,9 +81,10 @@ void LoginUIService::DisplayLoginResult(Browser* browser,

#endif

last_login_result_ = message;

browser->window()->ShowAvatarBubbleFromAvatarButton(

- message.empty() ? BrowserWindow::AVATAR_BUBBLE_MODE_CONFIRM_SIGNIN :

- BrowserWindow::AVATAR_BUBBLE_MODE_SHOW_ERROR,

- signin::ManageAccountsParams());

+ message.empty() ? BrowserWindow::AVATAR_BUBBLE_MODE_CONFIRM_SIGNIN

+ : BrowserWindow::AVATAR_BUBBLE_MODE_SHOW_ERROR,

+ signin::ManageAccountsParams(),

+ signin_metrics::AccessPoint::ACCESS_POINT_EXTENSIONS);

}

const base::string16& LoginUIService::GetLastLoginResult() {