Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: chrome/browser/ui/webui/options/sync_setup_handler.h

Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: format Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/sync_setup_handler.h
diff --git a/chrome/browser/ui/webui/options/sync_setup_handler.h b/chrome/browser/ui/webui/options/sync_setup_handler.h
index 0065eccb97f0f482481c2c870fa79894f84f5ea0..86ac6bcca3799a56eae3a4a5413346e306d787a7 100644
--- a/chrome/browser/ui/webui/options/sync_setup_handler.h
+++ b/chrome/browser/ui/webui/options/sync_setup_handler.h
@@ -20,6 +20,10 @@ namespace content {
class WebContents;
}
+namespace signin_metrics {
+enum class AccessPoint;
+}
+
class SyncSetupHandler : public options::OptionsPageUIHandler,
public SyncStartupTracker::Observer,
public LoginUIService::LoginUI {
@@ -44,7 +48,7 @@ class SyncSetupHandler : public options::OptionsPageUIHandler,
content::WebUI* web_ui);
// Initializes the sync setup flow and shows the setup UI.
- void OpenSyncSetup();
+ void OpenSyncSetup(const base::ListValue* args);
// Shows advanced configuration dialog without going through sign in dialog.
// Kicks the sync backend if necessary with showing spinner dialog until it
@@ -105,11 +109,12 @@ class SyncSetupHandler : public options::OptionsPageUIHandler,
void HandleCloseTimeout(const base::ListValue* args);
#if !defined(OS_CHROMEOS)
// Displays the GAIA login form.
- void DisplayGaiaLogin();
+ void DisplayGaiaLogin(signin_metrics::AccessPoint access_point);
// When web-flow is enabled, displays the Gaia login form in a new tab.
// This function is virtual so that tests can override.
- virtual void DisplayGaiaLoginInNewTabOrWindow();
+ virtual void DisplayGaiaLoginInNewTabOrWindow(
+ signin_metrics::AccessPoint access_point);
#endif
// Helper routine that gets the Profile associated with this object (virtual
« no previous file with comments | « chrome/browser/ui/webui/ntp/new_tab_page_sync_handler.cc ('k') | chrome/browser/ui/webui/options/sync_setup_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698