Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1373)

Unified Diff: chrome/browser/ui/webui/app_launcher_login_handler.cc

Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: format Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/app_launcher_login_handler.cc
diff --git a/chrome/browser/ui/webui/app_launcher_login_handler.cc b/chrome/browser/ui/webui/app_launcher_login_handler.cc
index c5cdb440d2d17b81fe5ff23470fd6358e0a92e53..460ec652ad89fc2640f103a26c6c94513c4270f7 100644
--- a/chrome/browser/ui/webui/app_launcher_login_handler.cc
+++ b/chrome/browser/ui/webui/app_launcher_login_handler.cc
@@ -126,11 +126,11 @@ void AppLauncherLoginHandler::HandleShowSyncLoginUI(
return;
// The user isn't signed in, show the sign in promo.
- signin_metrics::Source source =
- web_contents->GetURL().spec() == chrome::kChromeUIAppsURL ?
- signin_metrics::SOURCE_APPS_PAGE_LINK :
- signin_metrics::SOURCE_NTP_LINK;
- chrome::ShowBrowserSignin(browser, source);
+ signin_metrics::AccessPoint access_point =
+ web_contents->GetURL().spec() == chrome::kChromeUIAppsURL
+ ? signin_metrics::AccessPoint::ACCESS_POINT_APPS_PAGE_LINK
+ : signin_metrics::AccessPoint::ACCESS_POINT_NTP_LINK;
+ chrome::ShowBrowserSignin(browser, access_point);
RecordInHistogram(NTP_SIGN_IN_PROMO_CLICKED);
}
@@ -157,10 +157,15 @@ void AppLauncherLoginHandler::HandleLoginMessageSeen(
void AppLauncherLoginHandler::HandleShowAdvancedLoginUI(
const base::ListValue* args) {
- Browser* browser =
- chrome::FindBrowserWithWebContents(web_ui()->GetWebContents());
- if (browser)
- chrome::ShowBrowserSignin(browser, signin_metrics::SOURCE_NTP_LINK);
+ content::WebContents* web_contents = web_ui()->GetWebContents();
+ Browser* browser = chrome::FindBrowserWithWebContents(web_contents);
+ if (!browser)
+ return;
+ signin_metrics::AccessPoint access_point =
+ web_contents->GetURL().spec() == chrome::kChromeUIAppsURL
+ ? signin_metrics::AccessPoint::ACCESS_POINT_APPS_PAGE_LINK
+ : signin_metrics::AccessPoint::ACCESS_POINT_NTP_LINK;
+ chrome::ShowBrowserSignin(browser, access_point);
}
void AppLauncherLoginHandler::UpdateLogin() {

Powered by Google App Engine
This is Rietveld 408576698