Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Unified Diff: chrome/browser/ui/sync/one_click_signin_sync_starter.cc

Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: format Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/sync/one_click_signin_sync_starter.cc
diff --git a/chrome/browser/ui/sync/one_click_signin_sync_starter.cc b/chrome/browser/ui/sync/one_click_signin_sync_starter.cc
index 61e6906612f8d85fedea7328cdf720a4e5eab0fb..6a0c0e148c5117f657de924736e6313d549e7a7c 100644
--- a/chrome/browser/ui/sync/one_click_signin_sync_starter.cc
+++ b/chrome/browser/ui/sync/one_click_signin_sync_starter.cc
@@ -79,6 +79,7 @@ OneClickSigninSyncStarter::OneClickSigninSyncStarter(
StartSyncMode start_mode,
content::WebContents* web_contents,
ConfirmationRequired confirmation_required,
+ const GURL& current_url,
const GURL& continue_url,
Callback sync_setup_completed_callback)
: content::WebContentsObserver(web_contents),
@@ -86,6 +87,7 @@ OneClickSigninSyncStarter::OneClickSigninSyncStarter(
start_mode_(start_mode),
desktop_type_(chrome::HOST_DESKTOP_TYPE_NATIVE),
confirmation_required_(confirmation_required),
+ current_url_(current_url),
continue_url_(continue_url),
sync_setup_completed_callback_(sync_setup_completed_callback),
weak_pointer_factory_(this) {
@@ -429,6 +431,12 @@ void OneClickSigninSyncStarter::SigninFailed(
}
void OneClickSigninSyncStarter::SigninSuccess() {
+ if (!current_url_.is_valid()) // Could be invalid for tests.
+ return;
+ signin_metrics::LogSigninAccessPointCompleted(
+ signin::GetAccessPointForPromoURL(current_url_));
+ signin_metrics::LogSigninReason(
+ signin::GetSigninReasonForPromoURL(current_url_));
}
void OneClickSigninSyncStarter::AccountAddedToCookie(

Powered by Google App Engine
This is Rietveld 408576698