Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1572)

Unified Diff: chrome/browser/profiles/host_zoom_map_browsertest.cc

Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: format Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/printing/print_dialog_cloud.cc ('k') | chrome/browser/resources/options/browser_options.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/profiles/host_zoom_map_browsertest.cc
diff --git a/chrome/browser/profiles/host_zoom_map_browsertest.cc b/chrome/browser/profiles/host_zoom_map_browsertest.cc
index f3d7764173fb504f7e1f01a61d166e23cecf5fba..aa2803a1310434aebbeb418dae98b25df487a62d 100644
--- a/chrome/browser/profiles/host_zoom_map_browsertest.cc
+++ b/chrome/browser/profiles/host_zoom_map_browsertest.cc
@@ -20,6 +20,7 @@
#include "base/values.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/profiles/profile_impl.h"
+#include "chrome/browser/signin/signin_promo.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/browser/ui/zoom/chrome_zoom_level_prefs.h"
@@ -126,6 +127,13 @@ class HostZoomMapBrowserTest : public InProcessBrowserTest {
return results;
}
+ std::string GetSigninPromoURL() {
+ return signin::GetPromoURL(
+ signin_metrics::AccessPoint::ACCESS_POINT_START_PAGE,
+ signin_metrics::Reason::REASON_SIGNIN_PRIMARY_ACCOUNT, false)
+ .spec();
+ }
+
GURL ConstructTestServerURL(const char* url_template) {
return GURL(base::StringPrintf(
url_template, embedded_test_server()->port()));
@@ -243,7 +251,7 @@ IN_PROC_BROWSER_TEST_F(HostZoomMapBrowserTest, ZoomEventsWorkForOffTheRecord) {
IN_PROC_BROWSER_TEST_F(
HostZoomMapBrowserTest,
WebviewBasedSigninUsesDefaultStoragePartitionForEmbedder) {
- GURL test_url = ConstructTestServerURL(chrome::kChromeUIChromeSigninURL);
+ GURL test_url = ConstructTestServerURL(GetSigninPromoURL().c_str());
std::string test_host(test_url.host());
std::string test_scheme(test_url.scheme());
ui_test_utils::NavigateToURL(browser(), test_url);
@@ -281,7 +289,7 @@ IN_PROC_BROWSER_TEST_F(HostZoomMapIframeSigninBrowserTest,
// test currently relies on the signin page being loaded into a non-default
// storage partition (and verifies this is the case), but ultimately it would
// be better not to rely on what the signin page is doing.
- GURL test_url = ConstructTestServerURL(chrome::kChromeUIChromeSigninURL);
+ GURL test_url = ConstructTestServerURL(GetSigninPromoURL().c_str());
std::string test_host(test_url.host());
std::string test_scheme(test_url.scheme());
ui_test_utils::NavigateToURL(browser(), test_url);
« no previous file with comments | « chrome/browser/printing/print_dialog_cloud.cc ('k') | chrome/browser/resources/options/browser_options.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698