chrome/browser/extensions/api/principals_private/principals_private_api.cc - Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/principals_private/principals_private_api.cc

Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: document signin.signinreason histogram Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/app_controller_mac.mm ('k') | chrome/browser/printing/print_dialog_cloud.cc » ('j') | chrome/browser/resources/options/sync_setup_overlay.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/principals_private/principals_private_api.cc

diff --git a/chrome/browser/extensions/api/principals_private/principals_private_api.cc b/chrome/browser/extensions/api/principals_private/principals_private_api.cc

index 491f4195f06ebf5f6156416dd4163224be91179c..867990d120f9f7e021831f55bf492ce7057a355d 100644

--- a/chrome/browser/extensions/api/principals_private/principals_private_api.cc

+++ b/chrome/browser/extensions/api/principals_private/principals_private_api.cc

@@ -10,6 +10,7 @@

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_window.h"

#include "components/signin/core/browser/signin_header_helper.h"

+#include "components/signin/core/browser/signin_metrics.h"

#include "components/signin/core/common/profile_management_switches.h"

namespace extensions {

@@ -36,7 +37,8 @@ bool PrincipalsPrivateShowAvatarBubbleFunction::RunSyncSafe() {

if (browser) {

browser->window()->ShowAvatarBubbleFromAvatarButton(

BrowserWindow::AVATAR_BUBBLE_MODE_ACCOUNT_MANAGEMENT,

- signin::ManageAccountsParams());

+ signin::ManageAccountsParams(),

+ signin_metrics::AccessPoint::ACCESS_POINT_AVATAR_BUBBLE_SIGN_IN);

}

return true;

}