Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7559)

Unified Diff: chrome/browser/ui/webui/signin/inline_login_handler.cc

Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add comments Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/signin/inline_login_handler.cc
diff --git a/chrome/browser/ui/webui/signin/inline_login_handler.cc b/chrome/browser/ui/webui/signin/inline_login_handler.cc
index f02145620f8654db225432864a203b6b2bfb16e4..6d1cea6acecc7236312b874f966d8ff6e9fe1625 100644
--- a/chrome/browser/ui/webui/signin/inline_login_handler.cc
+++ b/chrome/browser/ui/webui/signin/inline_login_handler.cc
@@ -69,17 +69,17 @@ void InlineLoginHandler::ContinueHandleInitializeMessage() {
params.SetInteger("authMode", InlineLoginHandler::kDesktopAuthMode);
const GURL& current_url = web_ui()->GetWebContents()->GetURL();
- signin_metrics::Source source = signin::GetSourceForPromoURL(current_url);
+ signin_metrics::AccessPoint access_point =
+ signin::GetAccessPointForPromoURL(current_url);
+ signin_metrics::LogSigninAccessPointStarted(access_point);
- params.SetString(
- "continueUrl",
- signin::GetLandingURL(signin::kSignInPromoQueryKeySource,
- static_cast<int>(source)).spec());
+ params.SetString("continueUrl", signin::GetLandingURL(access_point).spec());
Profile* profile = Profile::FromWebUI(web_ui());
+ signin_metrics::Reason reason =
+ signin::GetSigninReasonForPromoURL(current_url);
std::string default_email;
- if (source != signin_metrics::SOURCE_AVATAR_BUBBLE_ADD_ACCOUNT &&
- source != signin_metrics::SOURCE_REAUTH) {
+ if (reason == signin_metrics::REASON_SIGNIN_PRIMARY_ACCOUNT) {
sky 2015/12/03 22:45:28 Isn't SOURCE_AVATAR_BUBBLE_ADD_ACCOUNT now ...SECO
gogerald1 2015/12/04 20:49:09 Yes, for other reasons there is an email key in th
default_email =
profile->GetPrefs()->GetString(prefs::kGoogleServicesLastUsername);
} else {

Powered by Google App Engine
This is Rietveld 408576698