Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7888)

Unified Diff: chrome/browser/ui/browser_window.h

Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add comments Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_window.h
diff --git a/chrome/browser/ui/browser_window.h b/chrome/browser/ui/browser_window.h
index b334c083c5d17408c0ea3d18c63245a7421d58e9..28d06ca6791b91ef23bec93fe925a6922880f3d2 100644
--- a/chrome/browser/ui/browser_window.h
+++ b/chrome/browser/ui/browser_window.h
@@ -17,6 +17,7 @@
#include "chrome/browser/ui/sync/one_click_signin_sync_starter.h"
#include "components/content_settings/core/common/content_settings_types.h"
#include "components/signin/core/browser/signin_header_helper.h"
+#include "components/signin/core/browser/signin_metrics.h"
#include "components/translate/core/common/translate_errors.h"
#include "ui/base/base_window.h"
#include "ui/base/window_open_disposition.h"
@@ -374,6 +375,8 @@ class BrowserWindow : public ui::BaseWindow {
// Shows the avatar bubble on the window frame off of the avatar button with
// the given mode. The Service Type specified by GAIA is provided as well.
+ // |access_point| indicates the access point used to open the Gaia sign in
+ // page.
enum AvatarBubbleMode {
AVATAR_BUBBLE_MODE_DEFAULT,
AVATAR_BUBBLE_MODE_ACCOUNT_MANAGEMENT,
@@ -384,11 +387,17 @@ class BrowserWindow : public ui::BaseWindow {
AVATAR_BUBBLE_MODE_SHOW_ERROR,
AVATAR_BUBBLE_MODE_FAST_USER_SWITCH,
};
- virtual void ShowAvatarBubbleFromAvatarButton(AvatarBubbleMode mode,
- const signin::ManageAccountsParams& manage_accounts_params) = 0;
+ virtual void ShowAvatarBubbleFromAvatarButton(
+ AvatarBubbleMode mode,
+ const signin::ManageAccountsParams& manage_accounts_params,
+ signin_metrics::AccessPoint access_point) = 0;
// Shows the signin flow for |mode| in a tab-modal dialog.
- virtual void ShowModalSigninWindow(AvatarBubbleMode mode) = 0;
+ // |access_point| indicates the access point used to open the Gaia sign in
+ // page.
+ virtual void ShowModalSigninWindow(
+ AvatarBubbleMode mode,
+ signin_metrics::AccessPoint access_point) = 0;
// Closes the tab-modal signin flow opened with ShowModalSigninWindow, if it's
// open. Does nothing otherwise.

Powered by Google App Engine
This is Rietveld 408576698