chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.cc - Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.cc

Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add comments Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/signin/signin_promo.cc ('K') | « chrome/browser/signin/signin_promo.cc ('k') | chrome/browser/ui/browser_command_controller.cc » ('j') | chrome/browser/ui/chrome_pages.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.cc

diff --git a/chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.cc b/chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.cc

index 6400e2d0fec60331a8ca400f8ab5bef4a9e712ac..3b72ba0c247d586cc2cc3bcc58bc77550299b59b 100644

--- a/chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.cc

+++ b/chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.cc

@@ -25,7 +25,8 @@ BookmarkBubbleSignInDelegate::~BookmarkBubbleSignInDelegate() {

void BookmarkBubbleSignInDelegate::OnSignInLinkClicked() {

EnsureBrowser();

- chrome::ShowBrowserSignin(browser_, signin_metrics::SOURCE_BOOKMARK_BUBBLE);

+ chrome::ShowBrowserSignin(browser_,

+ signin_metrics::ACCESS_POINT_BOOKMARK_BUBBLE);

}

void BookmarkBubbleSignInDelegate::OnBrowserRemoved(Browser* browser) {

« chrome/browser/signin/signin_promo.cc ('K') | « chrome/browser/signin/signin_promo.cc ('k') | chrome/browser/ui/browser_command_controller.cc » ('j') | chrome/browser/ui/chrome_pages.cc » ('J')