chrome/browser/resources/options/sync_setup_overlay.js - Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/sync_setup_overlay.js

Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add comments Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/profiles/host_zoom_map_browsertest.cc ('K') | « chrome/browser/resources/options/manage_profile_overlay.js ('k') | chrome/browser/signin/chrome_signin_helper.cc » ('j') | chrome/browser/signin/signin_promo.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/sync_setup_overlay.js

diff --git a/chrome/browser/resources/options/sync_setup_overlay.js b/chrome/browser/resources/options/sync_setup_overlay.js

index 4b5944987f3996d624c882143e572dc8eba5d77d..fa6befa1071914c10f3025ca5ab44399301b481e 100644

--- a/chrome/browser/resources/options/sync_setup_overlay.js

+++ b/chrome/browser/resources/options/sync_setup_overlay.js

@@ -827,8 +827,8 @@ cr.define('options', function() {

* already signed in.

* @private

- startSignIn_: function() {

- chrome.send('SyncSetupStartSignIn');

+ startSignIn_: function(accessPoint) {

+ chrome.send('SyncSetupStartSignIn', [accessPoint]);

/**

@@ -849,8 +849,8 @@ cr.define('options', function() {

SyncSetupOverlay.getInstance().showSetupUI_();

};

- SyncSetupOverlay.startSignIn = function() {

- SyncSetupOverlay.getInstance().startSignIn_();

+ SyncSetupOverlay.startSignIn = function(accessPoint) {

+ SyncSetupOverlay.getInstance().startSignIn_(accessPoint);

};

SyncSetupOverlay.doSignOutOnAuthError = function() {