chrome/browser/app_controller_mac.mm - Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/app_controller_mac.mm

Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add comments Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/extensions/api/principals_private/principals_private_api.cc » ('j') | chrome/browser/profiles/host_zoom_map_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/app_controller_mac.mm

diff --git a/chrome/browser/app_controller_mac.mm b/chrome/browser/app_controller_mac.mm

index 8ec1516b7b4557ba8cb2395f64f0bdccd8ee7e14..86f481ac514c33225ea53716c2a8ab7f769caa64 100644

--- a/chrome/browser/app_controller_mac.mm

+++ b/chrome/browser/app_controller_mac.mm

@@ -1127,9 +1127,10 @@ class AppControllerProfileObserver : public ProfileInfoCacheObserver {

case IDC_SHOW_SYNC_SETUP:

if (Browser* browser = ActivateBrowser(lastProfile)) {

chrome::ShowBrowserSigninOrSettings(browser,

- signin_metrics::SOURCE_MENU);

+ signin_metrics::ACCESS_POINT_MENU);

} else {

- chrome::OpenSyncSetupWindow(lastProfile, signin_metrics::SOURCE_MENU);

+ chrome::OpenSyncSetupWindow(lastProfile,

+ signin_metrics::ACCESS_POINT_MENU);

}

break;

case IDC_TASK_MANAGER: