Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1286)

Unified Diff: chrome/browser/ui/sync/one_click_signin_sync_starter.cc

Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase (Minute Maid sign in flow) Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/sync/one_click_signin_sync_starter.cc
diff --git a/chrome/browser/ui/sync/one_click_signin_sync_starter.cc b/chrome/browser/ui/sync/one_click_signin_sync_starter.cc
index 61e6906612f8d85fedea7328cdf720a4e5eab0fb..f55557cfe2bb337f18462c18839f0009110bd6ea 100644
--- a/chrome/browser/ui/sync/one_click_signin_sync_starter.cc
+++ b/chrome/browser/ui/sync/one_click_signin_sync_starter.cc
@@ -429,6 +429,11 @@ void OneClickSigninSyncStarter::SigninFailed(
}
void OneClickSigninSyncStarter::SigninSuccess() {
+ const GURL& current_url = web_contents()->GetURL();
Roger Tawa OOO till Jul 10th 2015/12/03 18:18:06 It seems the web contents could be null sometimes.
gogerald1 2015/12/03 19:03:18 Done.
+ signin_metrics::LogSigninAccessPointCompleted(
+ signin::GetAccessPointForPromoURL(current_url));
+ signin_metrics::LogSigninReason(
+ signin::GetSigninReasonForPromoURL(current_url));
}
void OneClickSigninSyncStarter::AccountAddedToCookie(
« no previous file with comments | « chrome/browser/ui/sync/one_click_signin_sync_observer_unittest.cc ('k') | chrome/browser/ui/user_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698