Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5900)

Unified Diff: chrome/browser/ui/webui/signin/login_ui_service.cc

Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/signin/login_ui_service.cc
diff --git a/chrome/browser/ui/webui/signin/login_ui_service.cc b/chrome/browser/ui/webui/signin/login_ui_service.cc
index cc1681d66027c04f8863d29436ae2f59706e142c..a18642d8a8f3550ba7ea8a59e0eda4d4532c242e 100644
--- a/chrome/browser/ui/webui/signin/login_ui_service.cc
+++ b/chrome/browser/ui/webui/signin/login_ui_service.cc
@@ -67,8 +67,8 @@ void LoginUIService::ShowLoginPopup() {
#else
chrome::ScopedTabbedBrowserDisplayer displayer(
profile_, chrome::GetActiveDesktop());
- chrome::ShowBrowserSignin(
- displayer.browser(), signin_metrics::SOURCE_APP_LAUNCHER);
+ chrome::ShowBrowserSignin(displayer.browser(),
+ signin_metrics::ACCESS_POINT_EXTENSIONS);
#endif
}
@@ -80,9 +80,9 @@ void LoginUIService::DisplayLoginResult(Browser* browser,
#endif
last_login_result_ = message;
browser->window()->ShowAvatarBubbleFromAvatarButton(
- message.empty() ? BrowserWindow::AVATAR_BUBBLE_MODE_CONFIRM_SIGNIN :
- BrowserWindow::AVATAR_BUBBLE_MODE_SHOW_ERROR,
- signin::ManageAccountsParams());
+ message.empty() ? BrowserWindow::AVATAR_BUBBLE_MODE_CONFIRM_SIGNIN
+ : BrowserWindow::AVATAR_BUBBLE_MODE_SHOW_ERROR,
+ signin::ManageAccountsParams(), signin_metrics::ACCESS_POINT_EXTENSIONS);
}
const base::string16& LoginUIService::GetLastLoginResult() {

Powered by Google App Engine
This is Rietveld 408576698