chrome/browser/ui/webui/signin/inline_login_handler_impl.h - Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/signin/inline_login_handler_impl.h

Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/signin/inline_login_handler.cc ('K') | « chrome/browser/ui/webui/signin/inline_login_handler.cc ('k') | chrome/browser/ui/webui/signin/inline_login_handler_impl.cc » ('j') | chrome/browser/ui/webui/signin/inline_login_handler_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/signin/inline_login_handler_impl.h

diff --git a/chrome/browser/ui/webui/signin/inline_login_handler_impl.h b/chrome/browser/ui/webui/signin/inline_login_handler_impl.h

index 138b4fb9e6062ea529864d7bb0553403867d43fd..61e4fa9bd475094ff5b5dc51c69e5d62940456de 100644

--- a/chrome/browser/ui/webui/signin/inline_login_handler_impl.h

+++ b/chrome/browser/ui/webui/signin/inline_login_handler_impl.h

@@ -170,7 +170,6 @@ class InlineSigninHelper : public GaiaAuthConsumer {

// cross account error, and false otherwise.

bool HandleCrossAccountError(

const std::string& refresh_token,

- signin_metrics::Source source,

OneClickSigninSyncStarter::ConfirmationRequired confirmation_required,

OneClickSigninSyncStarter::StartSyncMode start_mode);

@@ -178,7 +177,6 @@ class InlineSigninHelper : public GaiaAuthConsumer {

void ConfirmEmailAction(

content::WebContents* web_contents,

const std::string& refresh_token,

- signin_metrics::Source source,

OneClickSigninSyncStarter::ConfirmationRequired confirmation_required,

OneClickSigninSyncStarter::StartSyncMode start_mode,

Action action);