Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: chrome/browser/ui/cocoa/browser_window_cocoa.mm

Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: format Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/cocoa/browser_window_cocoa.h" 5 #include "chrome/browser/ui/cocoa/browser_window_cocoa.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #import "base/mac/sdk_forward_declarations.h" 10 #import "base/mac/sdk_forward_declarations.h"
(...skipping 822 matching lines...) Expand 10 before | Expand all | Expand 10 after
833 // at this point the controller is dead (autoreleased), so 833 // at this point the controller is dead (autoreleased), so
834 // make sure we don't try to reference it any more. 834 // make sure we don't try to reference it any more.
835 } 835 }
836 836
837 NSWindow* BrowserWindowCocoa::window() const { 837 NSWindow* BrowserWindowCocoa::window() const {
838 return [controller_ window]; 838 return [controller_ window];
839 } 839 }
840 840
841 void BrowserWindowCocoa::ShowAvatarBubbleFromAvatarButton( 841 void BrowserWindowCocoa::ShowAvatarBubbleFromAvatarButton(
842 AvatarBubbleMode mode, 842 AvatarBubbleMode mode,
843 const signin::ManageAccountsParams& manage_accounts_params) { 843 const signin::ManageAccountsParams& manage_accounts_params,
844 signin_metrics::AccessPoint access_point) {
844 AvatarBaseController* controller = [controller_ avatarButtonController]; 845 AvatarBaseController* controller = [controller_ avatarButtonController];
845 NSView* anchor = [controller buttonView]; 846 NSView* anchor = [controller buttonView];
846 if ([anchor isHiddenOrHasHiddenAncestor]) 847 if ([anchor isHiddenOrHasHiddenAncestor])
847 anchor = [[controller_ toolbarController] wrenchButton]; 848 anchor = [[controller_ toolbarController] wrenchButton];
848 [controller showAvatarBubbleAnchoredAt:anchor 849 [controller showAvatarBubbleAnchoredAt:anchor
849 withMode:mode 850 withMode:mode
850 withServiceType:manage_accounts_params.service_type]; 851 withServiceType:manage_accounts_params.service_type
852 fromAccessPoint:access_point];
851 } 853 }
852 854
853 void BrowserWindowCocoa::ShowModalSigninWindow(AvatarBubbleMode mode) { 855 void BrowserWindowCocoa::ShowModalSigninWindow(
856 AvatarBubbleMode mode,
857 signin_metrics::AccessPoint access_point) {
854 NOTREACHED(); 858 NOTREACHED();
855 } 859 }
856 void BrowserWindowCocoa::CloseModalSigninWindow() { 860 void BrowserWindowCocoa::CloseModalSigninWindow() {
857 NOTREACHED(); 861 NOTREACHED();
858 } 862 }
859 863
860 int 864 int
861 BrowserWindowCocoa::GetRenderViewHeightInsetWithDetachedBookmarkBar() { 865 BrowserWindowCocoa::GetRenderViewHeightInsetWithDetachedBookmarkBar() {
862 if (browser_->bookmark_bar_state() != BookmarkBar::DETACHED) 866 if (browser_->bookmark_bar_state() != BookmarkBar::DETACHED)
863 return 0; 867 return 0;
(...skipping 21 matching lines...) Expand all
885 void BrowserWindowCocoa::UnhideDownloadShelf() { 889 void BrowserWindowCocoa::UnhideDownloadShelf() {
886 GetDownloadShelf()->Unhide(); 890 GetDownloadShelf()->Unhide();
887 } 891 }
888 892
889 void BrowserWindowCocoa::HideDownloadShelf() { 893 void BrowserWindowCocoa::HideDownloadShelf() {
890 GetDownloadShelf()->Hide(); 894 GetDownloadShelf()->Hide();
891 StatusBubble* statusBubble = GetStatusBubble(); 895 StatusBubble* statusBubble = GetStatusBubble();
892 if (statusBubble) 896 if (statusBubble)
893 statusBubble->Hide(); 897 statusBubble->Hide();
894 } 898 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698