chrome/browser/ui/cocoa/bookmarks/bookmark_sync_promo_controller.mm - Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_sync_promo_controller.mm

Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: format Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/ui/chrome_pages.cc ('k') | chrome/browser/ui/cocoa/browser_window_cocoa.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_sync_promo_controller.h"	5 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_sync_promo_controller.h"

6	6

7 #include "base/strings/sys_string_conversions.h"	7 #include "base/strings/sys_string_conversions.h"

8 #include "chrome/browser/signin/signin_promo.h"	8 #include "chrome/browser/signin/signin_promo.h"

9 #include "chrome/browser/ui/chrome_pages.h"	9 #include "chrome/browser/ui/chrome_pages.h"

10 #include "chrome/browser/ui/chrome_style.h"	10 #include "chrome/browser/ui/chrome_style.h"

(...skipping 90 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
101 [textView_ setDelegate:self];	101 [textView_ setDelegate:self];

102	102

103 [promoView setContentView:textView_];	103 [promoView setContentView:textView_];

104	104

105 [self setView:promoView];	105 [self setView:promoView];

106 }	106 }

107	107

108 - (BOOL)textView:(NSTextView *)textView	108 - (BOOL)textView:(NSTextView *)textView

109 clickedOnLink:(id)link	109 clickedOnLink:(id)link

110 atIndex:(NSUInteger)charIndex {	110 atIndex:(NSUInteger)charIndex {

111 chrome::ShowBrowserSignin(browser_, signin_metrics::SOURCE_BOOKMARK_BUBBLE);	111 chrome::ShowBrowserSignin(

	112 browser_, signin_metrics::AccessPoint::ACCESS_POINT_BOOKMARK_BUBBLE);

112 return YES;	113 return YES;

113 }	114 }

114	115

115 @end	116 @end

OLD	NEW