Implement newly designed sign-in related histograms for desktop platorms.

chrome/browser/ui/browser_window.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_BROWSER_WINDOW_H_
 #define CHROME_BROWSER_UI_BROWSER_WINDOW_H_
 
 #include "base/callback_forward.h"
 #include "chrome/browser/lifetime/browser_close_manager.h"
 #include "chrome/browser/signin/chrome_signin_helper.h"
@@ skipping 43 matching lines @@
 
 namespace gfx {
 class Rect;
 class Size;
 }
 
 namespace web_modal {
 class WebContentsModalDialogHost;
 }
 
+namespace signin_metrics {

[Bernhard Bauer, 2015/12/07 12:14:54]

Keep the namespaces ordered alphabetically. Also, do you need to specify an
underlying type?

[gogerald1, 2015/12/07 16:45:30]

Done. Specify underlying type to make explicit conversion clear.

[Bernhard Bauer, 2015/12/07 16:49:27]

Well, do we need to repeat this everywhere this enum is forward-declared? It
just seems somewhat redundant, as any place that actually deals with it probably
needs the full definition anyway.

+enum class AccessPoint : int;
+}
+
 ////////////////////////////////////////////////////////////////////////////////
 // BrowserWindow interface
 //  An interface implemented by the "view" of the Browser window.
 //  This interface includes ui::BaseWindow methods as well as Browser window
 //  specific methods.
 //
 // NOTE: All getters may return NULL.
 //
 class BrowserWindow : public ui::BaseWindow {
  public:
@@ skipping 293 matching lines @@
   static BrowserWindow* CreateBrowserWindow(Browser* browser);
 
   // Returns a HostDesktopType that is compatible with the current Chrome window
   // configuration. On Windows with Ash, this is always HOST_DESKTOP_TYPE_ASH
   // while Chrome is running in Metro mode. Otherwise returns |desktop_type|.
   static chrome::HostDesktopType AdjustHostDesktopType(
       chrome::HostDesktopType desktop_type);
 
   // Shows the avatar bubble on the window frame off of the avatar button with
   // the given mode. The Service Type specified by GAIA is provided as well.
+  // |access_point| indicates the access point used to open the Gaia sign in
+  // page.
   enum AvatarBubbleMode {
     AVATAR_BUBBLE_MODE_DEFAULT,
     AVATAR_BUBBLE_MODE_ACCOUNT_MANAGEMENT,
     AVATAR_BUBBLE_MODE_SIGNIN,
     AVATAR_BUBBLE_MODE_ADD_ACCOUNT,
     AVATAR_BUBBLE_MODE_REAUTH,
     AVATAR_BUBBLE_MODE_CONFIRM_SIGNIN,
     AVATAR_BUBBLE_MODE_SHOW_ERROR,
     AVATAR_BUBBLE_MODE_FAST_USER_SWITCH,
   };
-  virtual void ShowAvatarBubbleFromAvatarButton(AvatarBubbleMode mode,
-      const signin::ManageAccountsParams& manage_accounts_params) = 0;
+  virtual void ShowAvatarBubbleFromAvatarButton(
+      AvatarBubbleMode mode,
+      const signin::ManageAccountsParams& manage_accounts_params,
+      signin_metrics::AccessPoint access_point) = 0;
 
   // Shows the signin flow for |mode| in a tab-modal dialog.
-  virtual void ShowModalSigninWindow(AvatarBubbleMode mode) = 0;
+  // |access_point| indicates the access point used to open the Gaia sign in
+  // page.
+  virtual void ShowModalSigninWindow(
+      AvatarBubbleMode mode,
+      signin_metrics::AccessPoint access_point) = 0;
 
   // Closes the tab-modal signin flow opened with ShowModalSigninWindow, if it's
   // open. Does nothing otherwise.
   virtual void CloseModalSigninWindow() = 0;
 
   // Returns the height inset for RenderView when detached bookmark bar is
   // shown.  Invoked when a new RenderHostView is created for a non-NTP
   // navigation entry and the bookmark bar is detached.
   virtual int GetRenderViewHeightInsetWithDetachedBookmarkBar() = 0;
 
   // Executes |command| registered by |extension|.
   virtual void ExecuteExtensionCommand(const extensions::Extension* extension,
                                        const extensions::Command& command) = 0;
 
   // Returns object implementing ExclusiveAccessContext interface.
   virtual ExclusiveAccessContext* GetExclusiveAccessContext() = 0;
 
  protected:
   friend class BrowserCloseManager;
   friend class BrowserView;
   virtual void DestroyBrowser() = 0;
 };
 
 #endif  // CHROME_BROWSER_UI_BROWSER_WINDOW_H_