Implement newly designed sign-in related histograms for desktop platorms.

chrome/browser/resources/options/sync_setup_overlay.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.exportPath('options');
 
 /** @typedef {{appsEnforced: boolean,
  *             appsRegistered: boolean,
  *             appsSynced: boolean,
  *             autofillEnforced: boolean,
@@ skipping 809 matching lines @@
     showSetupUI_: function() {
       chrome.send('SyncSetupShowSetupUI');
       chrome.send('coreOptionsUserMetricsAction', ['Options_ShowSyncAdvanced']);
     },
 
     /**
      * Starts the signin process for the user. Does nothing if the user is
      * already signed in.
      * @private
      */
-    startSignIn_: function() {
-      chrome.send('SyncSetupStartSignIn');
+    startSignIn_: function(accessPoint) {
+      chrome.send('SyncSetupStartSignIn', [accessPoint]);
     },
 
     /**
      * Forces user to sign out of Chrome for Chrome OS.
      * @private
      */
     doSignOutOnAuthError_: function() {
       chrome.send('SyncSetupDoSignOutOnAuthError');
     },
   };
 
-  // These methods are for general consumption.
-  SyncSetupOverlay.closeOverlay = function() {
-    SyncSetupOverlay.getInstance().closeOverlay_();
-  };
-
-  SyncSetupOverlay.showSetupUI = function() {
-    SyncSetupOverlay.getInstance().showSetupUI_();
-  };
-
-  SyncSetupOverlay.startSignIn = function() {
-    SyncSetupOverlay.getInstance().startSignIn_();
-  };
-
-  SyncSetupOverlay.doSignOutOnAuthError = function() {
-    SyncSetupOverlay.getInstance().doSignOutOnAuthError_();
-  };
-
-  SyncSetupOverlay.showSyncSetupPage = function(page, args) {
-    SyncSetupOverlay.getInstance().showSyncSetupPage_(page, args);
-  };
-
-  SyncSetupOverlay.showCustomizePage = function(args, index) {
-    SyncSetupOverlay.getInstance().showCustomizePage_(args, index);
-  };
-
-  SyncSetupOverlay.showStopSyncingUI = function() {
-    SyncSetupOverlay.getInstance().showStopSyncingUI_();
-  };
+  // Forward public APIs to private implementations.
+  cr.makePublic(SyncSetupOverlay, [
+    'closeOverlay',
+    'showSetupUI',
+    'startSignIn',
+    'doSignOutOnAuthError',
+    'showSyncSetupPage',
+    'showCustomizePage',
+    'showStopSyncingUI',
+    ]);

[Bernhard Bauer, 2015/12/07 12:14:54]

This line should be indented two spaces less.

[gogerald1, 2015/12/07 16:45:29]

Done.

[Bernhard Bauer, 2015/12/07 16:49:27]

_Two_ spaces less. You removed four, so now it's two more 😃

 
   // Export
   return {
     SyncSetupOverlay: SyncSetupOverlay
   };
 });