Implement newly designed sign-in related histograms for desktop platorms.

components/signin/core/browser/signin_metrics.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_SIGNIN_CORE_BROWSER_SIGNIN_METRICS_H_
 #define COMPONENTS_SIGNIN_CORE_BROWSER_SIGNIN_METRICS_H_
 
 #include "base/time/time.h"
 
 #include "google_apis/gaia/google_service_auth_error.h"
@@ skipping 80 matching lines @@
   HISTOGRAM_CONFIRM_LEARN_MORE,
   HISTOGRAM_CONFIRM_LEARN_MORE_OK,
   HISTOGRAM_CONFIRM_LEARN_MORE_RETURN,
   HISTOGRAM_CONFIRM_LEARN_MORE_ADVANCED,
   HISTOGRAM_CONFIRM_LEARN_MORE_CLOSE,
   HISTOGRAM_CONFIRM_LEARN_MORE_ESCAPE,
   HISTOGRAM_CONFIRM_LEARN_MORE_UNDO,
   HISTOGRAM_CONFIRM_MAX
 };
 
-// Enum valus used with the "Signin.SigninSource" histogram, which tracks the
-// source that launched a Gaia signin page.
+// TODO(gogerald): right now, gaia server needs to distinguish the source from
+// signin_metrics::SOURCE_START_PAGE, signin_metrics::SOURCE_SETTINGS and the
+// others to show advanced sync setting, remove them after switching to Minute
+// Maid sign in flow.
 enum Source {
-  SOURCE_START_PAGE = 0, // This must be first.
-  SOURCE_NTP_LINK,
-  SOURCE_MENU,
-  SOURCE_SETTINGS,
-  SOURCE_EXTENSION_INSTALL_BUBBLE,
-  SOURCE_APP_LAUNCHER,
-  SOURCE_APPS_PAGE_LINK,
-  SOURCE_BOOKMARK_BUBBLE,
-  SOURCE_AVATAR_BUBBLE_SIGN_IN,
-  SOURCE_AVATAR_BUBBLE_ADD_ACCOUNT,
-  SOURCE_DEVICES_PAGE,
-  SOURCE_REAUTH,
-  SOURCE_UNKNOWN, // This must be last.
+  SOURCE_START_PAGE = 0,  // This must be first.
+  SOURCE_SETTINGS = 3,
+  SOURCE_OTHERS,
+};
+
+// Enum values which enumerates all access points where sign in could be
+// initiated. Not all of them exist on all platforms. They are used with
+// "Signin.SigninStartedAccessPoint" and "Signin.SigninCompletedAccessPoint"
+// histograms.
+enum AccessPoint {

[sky, 2015/12/03 22:45:28]

As you're changing all this around it would be nice if you used enum class so
that you could forward declare these and not have to include the header in all
the .h files.

[gogerald1, 2015/12/04 20:49:09]

Done.

+  ACCESS_POINT_START_PAGE = 0,
+  ACCESS_POINT_NTP_LINK,
+  ACCESS_POINT_MENU,
+  ACCESS_POINT_SETTINGS,
+  ACCESS_POINT_SUPERVISED_USER,
+  ACCESS_POINT_EXTENSION_INSTALL_BUBBLE,
+  ACCESS_POINT_EXTENSIONS,
+  ACCESS_POINT_APPS_PAGE_LINK,
+  ACCESS_POINT_BOOKMARK_BUBBLE,
+  ACCESS_POINT_BOOKMARK_MANAGER,
+  ACCESS_POINT_AVATAR_BUBBLE_SIGN_IN,
+  ACCESS_POINT_USER_MANAGER,
+  ACCESS_POINT_DEVICES_PAGE,
+  ACCESS_POINT_CLOUD_PRINT,
+  ACCESS_POINT_CONTENT_AREA,
+  ACCESS_POINT_SIGNIN_PROMO,
+  ACCESS_POINT_RECENT_TABS,
+  ACCESS_POINT_MAX  // This must be last.
+};
+
+// Enum values which enumerates all reasons to start sign in process.
+enum Reason {
+  REASON_SIGNIN_PRIMARY_ACCOUNT = 0,
+  REASON_ADD_SECONDARY_ACCOUNT,
+  REASON_REAUTHENTICATION,
+  REASON_UNLOCK,
+  REASON_MAX  // This must be last.
 };
 
 // Enum values used for use with the "Signin.Reauth" histogram.
 enum AccountReauth {
   // The user gave the wrong email when doing a reauthentication.
   HISTOGRAM_ACCOUNT_MISSMATCH,
   // The user was shown a reauthentication login screen.
   HISTOGRAM_REAUTH_SHOWN,
 
   HISTOGRAM_REAUTH_MAX
@@ skipping 43 matching lines @@
   // The AccountReconcilor has finished running ans is up-to-date.
   ACCOUNT_RECONCILOR_OK,
   // The AccountReconcilor is running and gathering information.
   ACCOUNT_RECONCILOR_RUNNING,
   // The AccountReconcilor encountered an error and stopped.
   ACCOUNT_RECONCILOR_ERROR,
   // Always the last enumerated type.
   ACCOUNT_RECONCILOR_HISTOGRAM_COUNT,
 };
 
+// Tracks the access point of sign in.
+void LogSigninAccessPointStarted(AccessPoint access_point);
+void LogSigninAccessPointCompleted(AccessPoint access_point);
+
+// Tracks the reason of sign in.
+void LogSigninReason(Reason reason);
+
 // Log to UMA histograms and UserCounts stats about a single execution of the
 // AccountReconciler.
 // |total_number_accounts| - How many accounts are in the browser for this
 //                           profile.
 // |count_added_to_cookie_jar| - How many accounts were in the browser but not
 //                               in the cookie jar.
 // |count_removed_from_cookie_jar| - How many accounts were in the cookie jar
 //                                   but not in the browser.
 // |primary_accounts_same| - False if the primary account for the cookie jar
 //                           and the token service were different; else true.
@@ skipping 10 matching lines @@
 
 // Logs duration of a single execution of AccountReconciler to UMA histograms.
 // |duration| - How long execution of AccountReconciler took.
 // |successful| - True if AccountReconciler was successful.
 void LogSigninAccountReconciliationDuration(base::TimeDelta duration,
                                             bool successful);
 
 // Track a successful signin.
 void LogSigninAddAccount();
 
-// Tracks the original source that showed the signin page.
-void LogSigninSource(Source source);
-
 // Track a successful signin of a profile.
 void LogSigninProfile(bool is_first_run, base::Time install_date);
 
 // Track a profile signout.
 void LogSignout(ProfileSignout metric);
 
 // Tracks whether the external connection results were all fetched before
 // the gaia cookie manager service tried to use them with merge session.
 // |time_to_check_connections| is the time it took to complete.
 void LogExternalCcResultFetches(
@@ skipping 12 matching lines @@
 void LogBrowsingSessionDuration(const base::Time& previous_activity_time);
 
 // Records the AccountReconcilor |state| when GAIA returns a specific response.
 // If |state| is different than ACCOUNT_RECONCILOR_OK it means the user will
 // be shown a different set of accounts in the content-area and the settings UI.
 void LogAccountReconcilorStateOnGaiaResponse(AccountReconcilorState state);
 
 }  // namespace signin_metrics
 
 #endif  // COMPONENTS_SIGNIN_CORE_BROWSER_SIGNIN_METRICS_H_