Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Side by Side Diff: chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc

Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add comments Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/extensions/extension_installed_bubble_view.h" 5 #include "chrome/browser/ui/views/extensions/extension_installed_bubble_view.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <string> 8 #include <string>
9 9
10 #include "chrome/browser/extensions/extension_action_manager.h" 10 #include "chrome/browser/extensions/extension_action_manager.h"
(...skipping 404 matching lines...) Expand 10 before | Expand all | Expand 10 after
415 bool did_close = bubble_reference_->CloseBubble(BUBBLE_CLOSE_ACCEPTED); 415 bool did_close = bubble_reference_->CloseBubble(BUBBLE_CLOSE_ACCEPTED);
416 DCHECK(did_close); 416 DCHECK(did_close);
417 417
418 if (source == sign_in_link_) { 418 if (source == sign_in_link_) {
419 #if defined(OS_ANDROID) 419 #if defined(OS_ANDROID)
420 // TODO(bshe): Figure out what to do on Android platform. See 420 // TODO(bshe): Figure out what to do on Android platform. See
421 // crbug.com/559340. 421 // crbug.com/559340.
422 NOTIMPLEMENTED(); 422 NOTIMPLEMENTED();
423 #else 423 #else
424 chrome::ShowBrowserSignin( 424 chrome::ShowBrowserSignin(
425 browser_, signin_metrics::SOURCE_EXTENSION_INSTALL_BUBBLE); 425 browser_, signin_metrics::ACCESS_POINT_EXTENSION_INSTALL_BUBBLE);
426 #endif 426 #endif
427 return; 427 return;
428 } 428 }
429 429
430 DCHECK_EQ(manage_shortcut_, source); 430 DCHECK_EQ(manage_shortcut_, source);
431 431
432 std::string configure_url = chrome::kChromeUIExtensionsURL; 432 std::string configure_url = chrome::kChromeUIExtensionsURL;
433 configure_url += chrome::kExtensionConfigureCommandsSubPage; 433 configure_url += chrome::kExtensionConfigureCommandsSubPage;
434 chrome::NavigateParams params(chrome::GetSingletonTabNavigateParams( 434 chrome::NavigateParams params(chrome::GetSingletonTabNavigateParams(
435 browser_, GURL(configure_url))); 435 browser_, GURL(configure_url)));
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
616 if (delegate_view_) { 616 if (delegate_view_) {
617 delegate_view_->GetWidget()->Close(); 617 delegate_view_->GetWidget()->Close();
618 delegate_view_ = nullptr; 618 delegate_view_ = nullptr;
619 } 619 }
620 } 620 }
621 621
622 void ExtensionInstalledBubbleUi::UpdateAnchorPosition() { 622 void ExtensionInstalledBubbleUi::UpdateAnchorPosition() {
623 DCHECK(delegate_view_); 623 DCHECK(delegate_view_);
624 delegate_view_->UpdateAnchorView(); 624 delegate_view_->UpdateAnchorView();
625 } 625 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698