Implement newly designed sign-in related histograms for desktop platorms.

chrome/browser/ui/webui/signin/inline_login_handler.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/signin/inline_login_handler.h"
 
 #include "base/bind.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 51 matching lines @@
 void InlineLoginHandler::ContinueHandleInitializeMessage() {
   base::DictionaryValue params;
 
   const std::string& app_locale = g_browser_process->GetApplicationLocale();
   params.SetString("hl", app_locale);
   GaiaUrls* gaiaUrls = GaiaUrls::GetInstance();
   params.SetString("gaiaUrl", gaiaUrls->gaia_url().spec());
   params.SetInteger("authMode", InlineLoginHandler::kDesktopAuthMode);
 
   const GURL& current_url = web_ui()->GetWebContents()->GetURL();
-  signin_metrics::Source source = signin::GetSourceForPromoURL(current_url);
+  signin_metrics::AccessPoint access_point =
+      signin::GetAccessPointForPromoURL(current_url);
+  signin_metrics::LogSigninAccessPoint(access_point, false);

[Roger Tawa OOO till Jul 10th, 2015/12/02 20:33:48]

Instead of a bool second arg, would be better to have an enum with values
STARTED and COMPLETED.  Or maybe even better to have separate functions:

signin_metrics::LogSigninAccessPointStarted(access_point);
signin_metrics::LogSigninAccessPointCompleted(access_point);

[gogerald1, 2015/12/03 17:49:03]

Done.

 
-  params.SetString(
-      "continueUrl",
-      signin::GetLandingURL(signin::kSignInPromoQueryKeySource,
-                            static_cast<int>(source)).spec());
+  params.SetString("continueUrl", signin::GetLandingURL(access_point).spec());
 
   Profile* profile = Profile::FromWebUI(web_ui());
+  signin_metrics::Reason reason =
+      signin::GetSigninReasonForPromoURL(current_url);
   std::string default_email;
-  if (source != signin_metrics::SOURCE_AVATAR_BUBBLE_ADD_ACCOUNT &&
-      source != signin_metrics::SOURCE_REAUTH) {
+  if (reason == signin_metrics::REASON_SIGNIN_PRIMARY_ACCOUNT) {
     default_email =
         profile->GetPrefs()->GetString(prefs::kGoogleServicesLastUsername);
   } else {
     if (!net::GetValueForKeyInQuery(current_url, "email", &default_email))
       default_email.clear();
   }
   if (!default_email.empty())
     params.SetString("email", default_email);
 
   std::string frame_url_id_str;
@@ skipping 51 matching lines @@
 
   chrome::NavigateParams params(
       profile,
       net::AppendOrReplaceQueryParameter(
           main_frame_url, signin::kSignInPromoQueryKeyConstrained, "0"),
       ui::PAGE_TRANSITION_AUTO_TOPLEVEL);
   chrome::Navigate(&params);
 
   web_ui()->CallJavascriptFunction("inline.login.closeDialog");
 }