Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Unified Diff: chrome/browser/ssl/security_state_model_android.cc

Issue 1473523002: Switch SecurityStateModel ownership to ChromeSecurityStateModelClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/security_state_model_android.cc
diff --git a/chrome/browser/ssl/security_state_model_android.cc b/chrome/browser/ssl/security_state_model_android.cc
index 34ea06e876df196e0bef09c23d157cc7dbc0dbfa..b6668344f486c7ea29482f7f74a99b854e0f8929 100644
--- a/chrome/browser/ssl/security_state_model_android.cc
+++ b/chrome/browser/ssl/security_state_model_android.cc
@@ -5,7 +5,7 @@
#include "chrome/browser/ssl/security_state_model_android.h"
#include "base/logging.h"
-#include "chrome/browser/ssl/security_state_model.h"
+#include "chrome/browser/ssl/chrome_security_state_model_client.h"
#include "content/public/browser/web_contents.h"
#include "jni/SecurityStateModel_jni.h"
@@ -22,10 +22,11 @@ jint GetSecurityLevelForWebContents(
content::WebContents* web_contents =
content::WebContents::FromJavaWebContents(jweb_contents);
DCHECK(web_contents);
- SecurityStateModel::CreateForWebContents(web_contents);
- SecurityStateModel* model = SecurityStateModel::FromWebContents(web_contents);
- DCHECK(model);
- return model->GetSecurityInfo().security_level;
+ ChromeSecurityStateModelClient::CreateForWebContents(web_contents);
+ ChromeSecurityStateModelClient* model_delegate =
blundell 2015/11/24 19:31:23 client :) (and so on throughout)
estark 2015/11/24 19:50:29 Done.
+ ChromeSecurityStateModelClient::FromWebContents(web_contents);
+ DCHECK(model_delegate);
+ return model_delegate->GetSecurityInfo().security_level;
}
// static
@@ -35,10 +36,11 @@ jboolean IsDeprecatedSHA1Present(JNIEnv* env,
content::WebContents* web_contents =
content::WebContents::FromJavaWebContents(jweb_contents);
DCHECK(web_contents);
- SecurityStateModel::CreateForWebContents(web_contents);
- SecurityStateModel* model = SecurityStateModel::FromWebContents(web_contents);
- DCHECK(model);
- return model->GetSecurityInfo().sha1_deprecation_status !=
+ ChromeSecurityStateModelClient::CreateForWebContents(web_contents);
+ ChromeSecurityStateModelClient* model_delegate =
+ ChromeSecurityStateModelClient::FromWebContents(web_contents);
+ DCHECK(model_delegate);
+ return model_delegate->GetSecurityInfo().sha1_deprecation_status !=
SecurityStateModel::NO_DEPRECATED_SHA1;
}
@@ -50,11 +52,12 @@ jboolean IsPassiveMixedContentPresent(
content::WebContents* web_contents =
content::WebContents::FromJavaWebContents(jweb_contents);
DCHECK(web_contents);
- SecurityStateModel::CreateForWebContents(web_contents);
- SecurityStateModel* model = SecurityStateModel::FromWebContents(web_contents);
- DCHECK(model);
- return model->GetSecurityInfo().mixed_content_status ==
+ ChromeSecurityStateModelClient::CreateForWebContents(web_contents);
+ ChromeSecurityStateModelClient* model_delegate =
+ ChromeSecurityStateModelClient::FromWebContents(web_contents);
+ DCHECK(model_delegate);
+ return model_delegate->GetSecurityInfo().mixed_content_status ==
SecurityStateModel::DISPLAYED_MIXED_CONTENT ||
- model->GetSecurityInfo().mixed_content_status ==
+ model_delegate->GetSecurityInfo().mixed_content_status ==
SecurityStateModel::RAN_AND_DISPLAYED_MIXED_CONTENT;
}

Powered by Google App Engine
This is Rietveld 408576698