Switch SecurityStateModel ownership to ChromeSecurityStateModelClient

Switch SecurityStateModel ownership to ChromeSecurityStateModelClient

ChromeSecurityStateModelClient is now the class that is attached to a
WebContents, instead of a SecurityStateModel. This is so that
SecurityStateModel can be componentized in a follow-up CL.

BUG=515071
TBR=sky@chromium.org

Committed: https://crrev.com/880a5a4e4ce4df061e36e7905f6c3f1a26ec5acb
Cr-Commit-Position: refs/heads/master@{#362162}

[estark, 2015-11-24 18:21:46]

estark@chromium.org changed reviewers:
+ blundell@chromium.org, felt@chromium.org

[estark, 2015-11-24 18:21:47]

felt, blundell, PTAL? As the next step of componentizing SecurityStateModel,
this CL switches things around so that the ChromeSecurityStateModelClient is
attached to a WebContents rather than the SecurityStateModel. SecurityStateModel
consumers now use the client instead.

[estark, 2015-11-24 18:22:55]

Description was changed from

==========
Switch SecurityStateModel ownership to ChromeSecurityStateModelDelegate

ChromeSecurityStateModelDelegate is now the class that is attached to a
WebContents, instead of a SecurityStateModel. This is so that
SecurityStateModel can be componentized in a follow-up CL.

BUG=515071
==========

to

==========
Switch SecurityStateModel ownership to ChromeSecurityStateModelClient

ChromeSecurityStateModelClient is now the class that is attached to a
WebContents, instead of a SecurityStateModel. This is so that
SecurityStateModel can be componentized in a follow-up CL.

BUG=515071
==========

[blundell, 2015-11-24 19:31:23]

LGTM

https://codereview.chromium.org/1473523002/diff/20001/chrome/browser/renderer...
File chrome/browser/renderer_context_menu/render_view_context_menu.cc (right):

https://codereview.chromium.org/1473523002/diff/20001/chrome/browser/renderer...
chrome/browser/renderer_context_menu/render_view_context_menu.cc:1951:
ChromeSecurityStateModelClient* security_model_delegate =
client :)

https://codereview.chromium.org/1473523002/diff/20001/chrome/browser/ssl/secu...
File chrome/browser/ssl/security_state_model_android.cc (right):

https://codereview.chromium.org/1473523002/diff/20001/chrome/browser/ssl/secu...
chrome/browser/ssl/security_state_model_android.cc:26:
ChromeSecurityStateModelClient* model_delegate =
client :) (and so on throughout)

[estark, 2015-11-24 19:50:29]

https://codereview.chromium.org/1473523002/diff/20001/chrome/browser/renderer...
File chrome/browser/renderer_context_menu/render_view_context_menu.cc (right):

https://codereview.chromium.org/1473523002/diff/20001/chrome/browser/renderer...
chrome/browser/renderer_context_menu/render_view_context_menu.cc:1951:
ChromeSecurityStateModelClient* security_model_delegate =
On 2015/11/24 19:31:23, blundell wrote:
> client :)

oops! Done

https://codereview.chromium.org/1473523002/diff/20001/chrome/browser/ssl/secu...
File chrome/browser/ssl/security_state_model_android.cc (right):

https://codereview.chromium.org/1473523002/diff/20001/chrome/browser/ssl/secu...
chrome/browser/ssl/security_state_model_android.cc:26:
ChromeSecurityStateModelClient* model_delegate =
On 2015/11/24 19:31:23, blundell wrote:
> client :) (and so on throughout)

Done.

[felt, 2015-11-25 23:52:13]

lgtm, looks like a pretty straightforward refactor

[estark, 2015-11-25 23:54:52]

estark@chromium.org changed reviewers:
+ sky@chromium.org

[estark, 2015-11-25 23:54:52]

Thanks felt.

sky: could you please review (mostly mechanical) changes to c/b/ui,
c/b/chromeos, c/b/renderer_context_menu?

[blundell, 2015-11-30 09:29:13]

On 2015/11/25 23:54:52, estark wrote:
> Thanks felt.
> 
> sky: could you please review (mostly mechanical) changes to c/b/ui,
> c/b/chromeos, c/b/renderer_context_menu?

(I think that all those changes easily fall under the guidelines for TBR'ing
based on "trivial client-side changes to an API for which you have an OWNERS
LGTM on the API change itself)

[estark, 2015-11-30 17:40:10]

Description was changed from

==========
Switch SecurityStateModel ownership to ChromeSecurityStateModelClient

ChromeSecurityStateModelClient is now the class that is attached to a
WebContents, instead of a SecurityStateModel. This is so that
SecurityStateModel can be componentized in a follow-up CL.

BUG=515071
==========

to

==========
Switch SecurityStateModel ownership to ChromeSecurityStateModelClient

ChromeSecurityStateModelClient is now the class that is attached to a
WebContents, instead of a SecurityStateModel. This is so that
SecurityStateModel can be componentized in a follow-up CL.

BUG=515071
TBR=sky@chromium.org
==========

[estark, 2015-11-30 17:40:27]

On 2015/11/30 09:29:13, blundell wrote:
> On 2015/11/25 23:54:52, estark wrote:
> > Thanks felt.
> > 
> > sky: could you please review (mostly mechanical) changes to c/b/ui,
> > c/b/chromeos, c/b/renderer_context_menu?
> 
> (I think that all those changes easily fall under the guidelines for TBR'ing
> based on "trivial client-side changes to an API for which you have an OWNERS
> LGTM on the API change itself)

Ok, thanks, adding sky@ as TBR

[estark, 2015-11-30 17:40:34]

The CQ bit was checked by estark@chromium.org

[commit-bot: I haz the power, 2015-11-30 17:41:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1473523002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1473523002/40001

[commit-bot: I haz the power, 2015-11-30 18:21:27]

Description was changed from

==========
Switch SecurityStateModel ownership to ChromeSecurityStateModelClient

ChromeSecurityStateModelClient is now the class that is attached to a
WebContents, instead of a SecurityStateModel. This is so that
SecurityStateModel can be componentized in a follow-up CL.

BUG=515071
TBR=sky@chromium.org
==========

to

==========
Switch SecurityStateModel ownership to ChromeSecurityStateModelClient

ChromeSecurityStateModelClient is now the class that is attached to a
WebContents, instead of a SecurityStateModel. This is so that
SecurityStateModel can be componentized in a follow-up CL.

BUG=515071
TBR=sky@chromium.org
==========

[commit-bot: I haz the power, 2015-11-30 18:21:29]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-30 18:22:13]

Description was changed from

==========
Switch SecurityStateModel ownership to ChromeSecurityStateModelClient

ChromeSecurityStateModelClient is now the class that is attached to a
WebContents, instead of a SecurityStateModel. This is so that
SecurityStateModel can be componentized in a follow-up CL.

BUG=515071
TBR=sky@chromium.org
==========

to

==========
Switch SecurityStateModel ownership to ChromeSecurityStateModelClient

ChromeSecurityStateModelClient is now the class that is attached to a
WebContents, instead of a SecurityStateModel. This is so that
SecurityStateModel can be componentized in a follow-up CL.

BUG=515071
TBR=sky@chromium.org

Committed: https://crrev.com/880a5a4e4ce4df061e36e7905f6c3f1a26ec5acb
Cr-Commit-Position: refs/heads/master@{#362162}
==========

[commit-bot: I haz the power, 2015-11-30 18:22:14]

Patchset 3 (id:??) landed as
https://crrev.com/880a5a4e4ce4df061e36e7905f6c3f1a26ec5acb
Cr-Commit-Position: refs/heads/master@{#362162}