Fix Win GN dbg build missing powrprof.lib

Fix Win GN dbg build missing powrprof.lib

TBR=raymes@chromium.org
BUG=546288
Committed: https://chromium.googlesource.com/chromium/src/+/d01d3720730602fdc8aeb19aa0b19ed6c5a5849c

[scottmg, 2015-11-25 23:35:40]

If this isn't enough, I'll revert both.

[scottmg, 2015-11-25 23:35:55]

Description was changed from

==========
Fix Win GN dbg build missing powrprof.lib

R=raymes@chromium.org
BUG=546288
==========

to

==========
Fix Win GN dbg build missing powrprof.lib

TBR=raymes@chromium.org
BUG=546288
==========

[commit-bot: I haz the power, 2015-11-25 23:41:17]

Description was changed from

==========
Fix Win GN dbg build missing powrprof.lib

TBR=raymes@chromium.org
BUG=546288
==========

to

==========
Fix Win GN dbg build missing powrprof.lib

TBR=raymes@chromium.org
BUG=546288

Committed: https://crrev.com/d01d3720730602fdc8aeb19aa0b19ed6c5a5849c
Cr-Commit-Position: refs/heads/master@{#361752}
==========

[commit-bot: I haz the power, 2015-11-25 23:41:17]

Patchset 1 (id:??) landed as
https://crrev.com/d01d3720730602fdc8aeb19aa0b19ed6c5a5849c
Cr-Commit-Position: refs/heads/master@{#361752}

[scottmg, 2015-11-25 23:41:43]

Description was changed from

==========
Fix Win GN dbg build missing powrprof.lib

TBR=raymes@chromium.org
BUG=546288

Committed: https://crrev.com/d01d3720730602fdc8aeb19aa0b19ed6c5a5849c
Cr-Commit-Position: refs/heads/master@{#361752}
==========

to

==========
Fix Win GN dbg build missing powrprof.lib

TBR=raymes@chromium.org
BUG=546288

Committed:
https://chromium.googlesource.com/chromium/src/+/d01d3720730602fdc8aeb19aa0b1...
==========

[scottmg, 2015-11-25 23:41:44]

Committed patchset #1 (id:1) manually as
d01d3720730602fdc8aeb19aa0b19ed6c5a5849c (tree was closed).

[Mark Mentovai, 2015-11-26 00:44:55]

mark@chromium.org changed reviewers:
+ mark@chromium.org

[Mark Mentovai, 2015-11-26 00:44:56]

LGTM

https://codereview.chromium.org/1473513007/diff/1/build/secondary/third_party...
File build/secondary/third_party/crashpad/crashpad/snapshot/BUILD.gn (right):

https://codereview.chromium.org/1473513007/diff/1/build/secondary/third_party...
build/secondary/third_party/crashpad/crashpad/snapshot/BUILD.gn:17: libs = [
"powrprof.lib" ]
snapshot.gyp has version.lib too.

[scottmg, 2015-11-26 00:59:13]

https://codereview.chromium.org/1473513007/diff/1/build/secondary/third_party...
File build/secondary/third_party/crashpad/crashpad/snapshot/BUILD.gn (right):

https://codereview.chromium.org/1473513007/diff/1/build/secondary/third_party...
build/secondary/third_party/crashpad/crashpad/snapshot/BUILD.gn:17: libs = [
"powrprof.lib" ]
On 2015/11/26 00:44:56, Mark Mentovai wrote:
> snapshot.gyp has version.lib too.

Thanks. It looks like Chrome has that in default_libs in the GN build files.
https://code.google.com/p/chromium/codesearch#chromium/src/build/config/BUILD...

I'm going to work on https://bugs.chromium.org/p/crashpad/issues/detail?id=79
tomorrow, so I'll leave it as-is for now, and try to make the gyp/gn match as
closely as makes sense in the Crashpad repo.

[scottmg, 2015-11-26 02:19:42]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1475543004/ by scottmg@chromium.org.

The reason for reverting is: Some failing tests
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%2....
Unclear why they didn't fail on trybots so I'm going to revert and investigate..