Refactor VisitProperty, add starting point for SIMD.js support.

Refactor VisitProperty, add starting point for SIMD.js support.

SIMD.js potentially adds to the standard library passed into
asm.js modules. Splitting off the point where the SIMD object
would be referenced to allow work on SIMD typing to occur orthogonally.

Adding VariableInfo to allow tracking of simd constructors / check functions. Using this for fround.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator
R=titzer@chromium.org,aseemgarg@chromium.org
LOG=N

Looking at simd.js

Committed: https://crrev.com/493fba88b2b01212eb1e2b68451a560464b49128
Cr-Commit-Position: refs/heads/master@{#32431}

[bradn, 2015-11-24 19:31:03]

Description was changed from

==========
Refactor VisitProperty, add starting point for SIMD.js support.

SIMD.js potentially adds to the standard library passed into
asm.js modules. Splitting off the point where the SIMD object
would be referenced to allow work on SIMD typing to occur orthogonally.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator
R=titzer@chromium.org,aseemgarg@chromium.org
LOG=N

Looking at simd.js
==========

to

==========
Refactor VisitProperty, add starting point for SIMD.js support.

SIMD.js potentially adds to the standard library passed into
asm.js modules. Splitting off the point where the SIMD object
would be referenced to allow work on SIMD typing to occur orthogonally.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator
R=titzer@chromium.org,aseemgarg@chromium.org
LOG=N

Looking at simd.js
==========

[titzer, 2015-11-24 19:38:03]

Looks good other than dancing

https://codereview.chromium.org/1473513004/diff/1/src/typing-asm.cc
File src/typing-asm.cc (right):

https://codereview.chromium.org/1473513004/diff/1/src/typing-asm.cc#newcode718
src/typing-asm.cc:718: if (key == NULL || !key->IsPropertyName() ||
Maybe we can factor out the Literal+IsPropertyName+IsUtf8EqualTo dance into a
helper?

[bradn, 2015-11-25 04:04:34]

Description was changed from

==========
Refactor VisitProperty, add starting point for SIMD.js support.

SIMD.js potentially adds to the standard library passed into
asm.js modules. Splitting off the point where the SIMD object
would be referenced to allow work on SIMD typing to occur orthogonally.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator
R=titzer@chromium.org,aseemgarg@chromium.org
LOG=N

Looking at simd.js
==========

to

==========
Refactor VisitProperty, add starting point for SIMD.js support.

SIMD.js potentially adds to the standard library passed into
asm.js modules. Splitting off the point where the SIMD object
would be referenced to allow work on SIMD typing to occur orthogonally.

Adding VariableInfo to allow tracking of simd constructors / check functions.
Using this for fround.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator
R=titzer@chromium.org,aseemgarg@chromium.org
LOG=N

Looking at simd.js
==========

[bradn, 2015-11-25 04:05:40]

https://codereview.chromium.org/1473513004/diff/1/src/typing-asm.cc
File src/typing-asm.cc (right):

https://codereview.chromium.org/1473513004/diff/1/src/typing-asm.cc#newcode718
src/typing-asm.cc:718: if (key == NULL || !key->IsPropertyName() ||
On 2015/11/24 19:38:02, titzer wrote:
> Maybe we can factor out the Literal+IsPropertyName+IsUtf8EqualTo dance into a
> helper?

Done.

[titzer, 2015-11-25 18:36:42]

https://codereview.chromium.org/1473513004/diff/20001/src/typing-asm.cc
File src/typing-asm.cc (right):

https://codereview.chromium.org/1473513004/diff/20001/src/typing-asm.cc#newco...
src/typing-asm.cc:742: Expression* AsmTyper::AsPropertyObjectWithKey(Expression*
expr,
This basically returns the "obj" in "obj.name" by matching against a literal
"name". That was hard to grok at first. Maybe a better name, like
GetReceiverOfPropertyAccess() ?

https://codereview.chromium.org/1473513004/diff/20001/src/typing-asm.h
File src/typing-asm.h (right):

https://codereview.chromium.org/1473513004/diff/20001/src/typing-asm.h#newcode41
src/typing-asm.h:41: bool is_constructor_function;
Maybe we can mark the stdlib variable right away with a boolean to make the
checks against it cheaper? There should only be one.

[bradn, 2015-11-30 18:22:38]

https://codereview.chromium.org/1473513004/diff/20001/src/typing-asm.cc
File src/typing-asm.cc (right):

https://codereview.chromium.org/1473513004/diff/20001/src/typing-asm.cc#newco...
src/typing-asm.cc:742: Expression* AsmTyper::AsPropertyObjectWithKey(Expression*
expr,
On 2015/11/25 18:36:42, titzer wrote:
> This basically returns the "obj" in "obj.name" by matching against a literal
> "name". That was hard to grok at first. Maybe a better name, like
> GetReceiverOfPropertyAccess() ?

Done.

https://codereview.chromium.org/1473513004/diff/20001/src/typing-asm.h
File src/typing-asm.h (right):

https://codereview.chromium.org/1473513004/diff/20001/src/typing-asm.h#newcode41
src/typing-asm.h:41: bool is_constructor_function;
On 2015/11/25 18:36:42, titzer wrote:
> Maybe we can mark the stdlib variable right away with a boolean to make the
> checks against it cheaper? There should only be one.

Done.

[titzer, 2015-11-30 20:40:14]

lgtm other than above comments.

https://codereview.chromium.org/1473513004/diff/40001/src/typing-asm.cc
File src/typing-asm.cc (right):

https://codereview.chromium.org/1473513004/diff/40001/src/typing-asm.cc#newco...
src/typing-asm.cc:794: #define V(NAME, Name, name, lane_count, lane_type)       
            \
That's a big hunk of code. Not sure how many types we have, but maybe we can
factor out some subroutines here.

https://codereview.chromium.org/1473513004/diff/40001/src/typing-asm.cc#newco...
src/typing-asm.cc:1304: void AsmTyper::SetVariableInfo(Variable* variable, const
VariableInfo* info) {
You probably need to initialize is_stdlib_object here as well.

[bradn, 2015-11-30 21:10:51]

https://codereview.chromium.org/1473513004/diff/40001/src/typing-asm.cc
File src/typing-asm.cc (right):

https://codereview.chromium.org/1473513004/diff/40001/src/typing-asm.cc#newco...
src/typing-asm.cc:794: #define V(NAME, Name, name, lane_count, lane_type)       
            \
On 2015/11/30 20:40:14, titzer wrote:
> That's a big hunk of code. Not sure how many types we have, but maybe we can
> factor out some subroutines here.

Done.

https://codereview.chromium.org/1473513004/diff/40001/src/typing-asm.cc#newco...
src/typing-asm.cc:1304: void AsmTyper::SetVariableInfo(Variable* variable, const
VariableInfo* info) {
On 2015/11/30 20:40:14, titzer wrote:
> You probably need to initialize is_stdlib_object here as well.

Done.

[bradn, 2015-12-01 02:15:28]

The CQ bit was checked by bradnelson@google.com

[bradn, 2015-12-01 02:15:29]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/1473513004/#ps100001
(title: "merge")

[commit-bot: I haz the power, 2015-12-01 02:15:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1473513004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1473513004/100001

[commit-bot: I haz the power, 2015-12-01 02:26:06]

Description was changed from

==========
Refactor VisitProperty, add starting point for SIMD.js support.

SIMD.js potentially adds to the standard library passed into
asm.js modules. Splitting off the point where the SIMD object
would be referenced to allow work on SIMD typing to occur orthogonally.

Adding VariableInfo to allow tracking of simd constructors / check functions.
Using this for fround.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator
R=titzer@chromium.org,aseemgarg@chromium.org
LOG=N

Looking at simd.js
==========

to

==========
Refactor VisitProperty, add starting point for SIMD.js support.

SIMD.js potentially adds to the standard library passed into
asm.js modules. Splitting off the point where the SIMD object
would be referenced to allow work on SIMD typing to occur orthogonally.

Adding VariableInfo to allow tracking of simd constructors / check functions.
Using this for fround.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator
R=titzer@chromium.org,aseemgarg@chromium.org
LOG=N

Looking at simd.js
==========

[commit-bot: I haz the power, 2015-12-01 02:26:08]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-12-01 02:28:25]

Description was changed from

==========
Refactor VisitProperty, add starting point for SIMD.js support.

SIMD.js potentially adds to the standard library passed into
asm.js modules. Splitting off the point where the SIMD object
would be referenced to allow work on SIMD typing to occur orthogonally.

Adding VariableInfo to allow tracking of simd constructors / check functions.
Using this for fround.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator
R=titzer@chromium.org,aseemgarg@chromium.org
LOG=N

Looking at simd.js
==========

to

==========
Refactor VisitProperty, add starting point for SIMD.js support.

SIMD.js potentially adds to the standard library passed into
asm.js modules. Splitting off the point where the SIMD object
would be referenced to allow work on SIMD typing to occur orthogonally.

Adding VariableInfo to allow tracking of simd constructors / check functions.
Using this for fround.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator
R=titzer@chromium.org,aseemgarg@chromium.org
LOG=N

Looking at simd.js

Committed: https://crrev.com/493fba88b2b01212eb1e2b68451a560464b49128
Cr-Commit-Position: refs/heads/master@{#32431}
==========

[commit-bot: I haz the power, 2015-12-01 02:28:26]

Patchset 6 (id:??) landed as
https://crrev.com/493fba88b2b01212eb1e2b68451a560464b49128
Cr-Commit-Position: refs/heads/master@{#32431}