Source/core/page/ChromeClient.h - Issue 14735003: Remove compile time flag ENABLE_PAGE_POPUP . This is part of an overall effort to remove unneeded c…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/ChromeClient.h

Issue 14735003: Remove compile time flag ENABLE_PAGE_POPUP . This is part of an overall effort to remove unneeded c… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebase Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/page/ChromeClient.h

diff --git a/Source/core/page/ChromeClient.h b/Source/core/page/ChromeClient.h

index f56e1f5fb39394283948f8651ec6614132c827a2..0d9ec58a9d00d7c2233c5a7d9b0625c85282cbd5 100644

--- a/Source/core/page/ChromeClient.h

+++ b/Source/core/page/ChromeClient.h

@@ -239,7 +239,6 @@ public:

// Checks if there is an opened popup, called by RenderMenuList::showPopup().

virtual bool hasOpenedPopup() const = 0;

virtual PassRefPtr<PopupMenu> createPopupMenu(PopupMenuClient*) const = 0;

-#if ENABLE(PAGE_POPUP)

// Creates a PagePopup object, and shows it beside originBoundsInRootView.

// The return value can be 0.

virtual PagePopup* openPagePopup(PagePopupClient*, const IntRect& originBoundsInRootView) = 0;

@@ -247,7 +246,6 @@ public:

// For testing.

virtual void setPagePopupDriver(PagePopupDriver*) = 0;

virtual void resetPagePopupDriver() = 0;

-#endif

// This function is called whenever a text field <input> is created. The

// implementation should return true if it wants to do something in

// addTextFieldDecorationsTo().

« no previous file with comments | « Source/core/loader/EmptyClients.h ('k') | Source/core/page/DOMWindowPagePopup.h » ('j') | no next file with comments »