Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Unified Diff: Source/WebKit/chromium/src/WebPagePopupImpl.cpp

Issue 14735003: Remove compile time flag ENABLE_PAGE_POPUP . This is part of an overall effort to remove unneeded c… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebase Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/WebKit/chromium/src/WebPagePopupImpl.h ('k') | Source/WebKit/chromium/src/WebViewImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebKit/chromium/src/WebPagePopupImpl.cpp
diff --git a/Source/WebKit/chromium/src/WebPagePopupImpl.cpp b/Source/WebKit/chromium/src/WebPagePopupImpl.cpp
index 8f0fa9ea1e6e705d59adf4dd876a590429811f01..e90cf55f4be831e02011898f7452bf126a0e4f9b 100644
--- a/Source/WebKit/chromium/src/WebPagePopupImpl.cpp
+++ b/Source/WebKit/chromium/src/WebPagePopupImpl.cpp
@@ -56,8 +56,6 @@ using namespace std;
namespace WebKit {
-#if ENABLE(PAGE_POPUP)
-
class PagePopupChromeClient : public EmptyChromeClient {
WTF_MAKE_NONCOPYABLE(PagePopupChromeClient);
WTF_MAKE_FAST_ALLOCATED;
@@ -341,13 +339,10 @@ void WebPagePopupImpl::closePopup()
m_popupClient->didClosePopup();
}
-#endif // ENABLE(PAGE_POPUP)
-
// WebPagePopup ----------------------------------------------------------------
WebPagePopup* WebPagePopup::create(WebWidgetClient* client)
{
-#if ENABLE(PAGE_POPUP)
if (!client)
CRASH();
// A WebPagePopupImpl instance usually has two references.
@@ -357,10 +352,6 @@ WebPagePopup* WebPagePopup::create(WebWidgetClient* client)
// We need them because the closing operation is asynchronous and the widget
// can be closed while the WebViewImpl is unaware of it.
return adoptRef(new WebPagePopupImpl(client)).leakRef();
-#else
- UNUSED_PARAM(client);
- return 0;
-#endif
}
} // namespace WebKit
« no previous file with comments | « Source/WebKit/chromium/src/WebPagePopupImpl.h ('k') | Source/WebKit/chromium/src/WebViewImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698