Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Side by Side Diff: Source/WebKit/chromium/src/WebViewImpl.h

Issue 14735003: Remove compile time flag ENABLE_PAGE_POPUP . This is part of an overall effort to remove unneeded c… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
116 class WebMouseWheelEvent; 116 class WebMouseWheelEvent;
117 class WebPagePopupImpl; 117 class WebPagePopupImpl;
118 class WebPrerendererClient; 118 class WebPrerendererClient;
119 class WebSettingsImpl; 119 class WebSettingsImpl;
120 class WebTouchEvent; 120 class WebTouchEvent;
121 class WebViewBenchmarkSupport; 121 class WebViewBenchmarkSupport;
122 122
123 class WebViewImpl : public WebView 123 class WebViewImpl : public WebView
124 , public RefCounted<WebViewImpl> 124 , public RefCounted<WebViewImpl>
125 , public WebGestureCurveTarget 125 , public WebGestureCurveTarget
126 #if ENABLE(PAGE_POPUP)
127 , public WebCore::PagePopupDriver 126 , public WebCore::PagePopupDriver
128 #endif
129 , public PageWidgetEventHandler { 127 , public PageWidgetEventHandler {
130 public: 128 public:
131 enum AutoZoomType { 129 enum AutoZoomType {
132 DoubleTap, 130 DoubleTap,
133 FindInPage, 131 FindInPage,
134 }; 132 };
135 133
136 // WebWidget methods: 134 // WebWidget methods:
137 virtual void close(); 135 virtual void close();
138 virtual WebSize size(); 136 virtual WebSize size();
(...skipping 356 matching lines...) Expand 10 before | Expand all | Expand 10 after
495 NotificationPresenterImpl* notificationPresenterImpl(); 493 NotificationPresenterImpl* notificationPresenterImpl();
496 #endif 494 #endif
497 495
498 // Tries to scroll a frame or any parent of a frame. Returns true if the vie w 496 // Tries to scroll a frame or any parent of a frame. Returns true if the vie w
499 // was scrolled. 497 // was scrolled.
500 bool propagateScroll(WebCore::ScrollDirection, WebCore::ScrollGranularity); 498 bool propagateScroll(WebCore::ScrollDirection, WebCore::ScrollGranularity);
501 499
502 // Notification that a popup was opened/closed. 500 // Notification that a popup was opened/closed.
503 void popupOpened(WebCore::PopupContainer* popupContainer); 501 void popupOpened(WebCore::PopupContainer* popupContainer);
504 void popupClosed(WebCore::PopupContainer* popupContainer); 502 void popupClosed(WebCore::PopupContainer* popupContainer);
505 #if ENABLE(PAGE_POPUP)
506 // PagePopupDriver functions. 503 // PagePopupDriver functions.
507 virtual WebCore::PagePopup* openPagePopup(WebCore::PagePopupClient*, const W ebCore::IntRect& originBoundsInRootView) OVERRIDE; 504 virtual WebCore::PagePopup* openPagePopup(WebCore::PagePopupClient*, const W ebCore::IntRect& originBoundsInRootView) OVERRIDE;
508 virtual void closePagePopup(WebCore::PagePopup*) OVERRIDE; 505 virtual void closePagePopup(WebCore::PagePopup*) OVERRIDE;
509 #endif
510 506
511 void hideAutofillPopup(); 507 void hideAutofillPopup();
512 508
513 // Creates a Helper Plugin of |pluginType| for |hostDocument|. 509 // Creates a Helper Plugin of |pluginType| for |hostDocument|.
514 WebHelperPluginImpl* createHelperPlugin(const String& pluginType, const WebD ocument& hostDocument); 510 WebHelperPluginImpl* createHelperPlugin(const String& pluginType, const WebD ocument& hostDocument);
515 511
516 // Returns the input event we're currently processing. This is used in some 512 // Returns the input event we're currently processing. This is used in some
517 // cases where the WebCore DOM event doesn't have the information we need. 513 // cases where the WebCore DOM event doesn't have the information we need.
518 static const WebInputEvent* currentInputEvent() 514 static const WebInputEvent* currentInputEvent()
519 { 515 {
(...skipping 10 matching lines...) Expand all
530 void setBackgroundColor(const WebCore::Color&); 526 void setBackgroundColor(const WebCore::Color&);
531 WebCore::GraphicsLayerFactory* graphicsLayerFactory() const; 527 WebCore::GraphicsLayerFactory* graphicsLayerFactory() const;
532 void registerForAnimations(WebLayer*); 528 void registerForAnimations(WebLayer*);
533 void scheduleAnimation(); 529 void scheduleAnimation();
534 530
535 void didProgrammaticallyScroll(const WebCore::IntPoint& scrollPoint); 531 void didProgrammaticallyScroll(const WebCore::IntPoint& scrollPoint);
536 532
537 virtual void setVisibilityState(WebPageVisibilityState, bool); 533 virtual void setVisibilityState(WebPageVisibilityState, bool);
538 534
539 WebCore::PopupContainer* selectPopup() const { return m_selectPopup.get(); } 535 WebCore::PopupContainer* selectPopup() const { return m_selectPopup.get(); }
540 #if ENABLE(PAGE_POPUP)
541 bool hasOpenedPopup() const { return m_selectPopup || m_pagePopup; } 536 bool hasOpenedPopup() const { return m_selectPopup || m_pagePopup; }
542 #else
543 bool hasOpenedPopup() const { return m_selectPopup; }
544 #endif
545 537
546 // Returns true if the event leads to scrolling. 538 // Returns true if the event leads to scrolling.
547 static bool mapKeyCodeForScroll(int keyCode, 539 static bool mapKeyCodeForScroll(int keyCode,
548 WebCore::ScrollDirection* scrollDirection, 540 WebCore::ScrollDirection* scrollDirection,
549 WebCore::ScrollGranularity* scrollGranularity ); 541 WebCore::ScrollGranularity* scrollGranularity );
550 542
551 // Called by a full frame plugin inside this view to inform it that its 543 // Called by a full frame plugin inside this view to inform it that its
552 // zoom level has been updated. The plugin should only call this function 544 // zoom level has been updated. The plugin should only call this function
553 // if the zoom change was triggered by the browser, it's only needed in case 545 // if the zoom change was triggered by the browser, it's only needed in case
554 // a plugin can update its own zoom, say because of its own UI. 546 // a plugin can update its own zoom, say because of its own UI.
(...skipping 228 matching lines...) Expand 10 before | Expand all | Expand 10 after
783 775
784 // The Autofill popup client. 776 // The Autofill popup client.
785 OwnPtr<AutofillPopupMenuClient> m_autofillPopupClient; 777 OwnPtr<AutofillPopupMenuClient> m_autofillPopupClient;
786 778
787 // The Autofill popup. 779 // The Autofill popup.
788 RefPtr<WebCore::PopupContainer> m_autofillPopup; 780 RefPtr<WebCore::PopupContainer> m_autofillPopup;
789 781
790 // The popup associated with a select element. 782 // The popup associated with a select element.
791 RefPtr<WebCore::PopupContainer> m_selectPopup; 783 RefPtr<WebCore::PopupContainer> m_selectPopup;
792 784
793 #if ENABLE(PAGE_POPUP)
794 // The popup associated with an input element. 785 // The popup associated with an input element.
795 RefPtr<WebPagePopupImpl> m_pagePopup; 786 RefPtr<WebPagePopupImpl> m_pagePopup;
796 #endif
797 787
798 OwnPtr<WebDevToolsAgentPrivate> m_devToolsAgent; 788 OwnPtr<WebDevToolsAgentPrivate> m_devToolsAgent;
799 OwnPtr<PageOverlayList> m_pageOverlays; 789 OwnPtr<PageOverlayList> m_pageOverlays;
800 790
801 // Whether the webview is rendering transparently. 791 // Whether the webview is rendering transparently.
802 bool m_isTransparent; 792 bool m_isTransparent;
803 793
804 // Whether the user can press tab to focus links. 794 // Whether the user can press tab to focus links.
805 bool m_tabsToLinks; 795 bool m_tabsToLinks;
806 796
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
870 860
871 bool m_showFPSCounter; 861 bool m_showFPSCounter;
872 bool m_showPaintRects; 862 bool m_showPaintRects;
873 bool m_showDebugBorders; 863 bool m_showDebugBorders;
874 bool m_continuousPaintingEnabled; 864 bool m_continuousPaintingEnabled;
875 }; 865 };
876 866
877 } // namespace WebKit 867 } // namespace WebKit
878 868
879 #endif 869 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698