Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 1473493003: Revert of [Intl] create new instances when new.target is undefined (Closed)

Created:
5 years ago by Dan Ehrenberg
Modified:
5 years ago
Reviewers:
caitp (gmail)
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [Intl] create new instances when new.target is undefined (patchset #2 id:20001 of https://codereview.chromium.org/1440593003/ ) Reason for revert: This breaks backwards compatibility by disallowing call. Web application authors have noticed the breakage. https://github.com/tc39/ecma402/issues/57 Original issue's description: > [Intl] create new instances when new.target is undefined > > BUG=v8:4360 > LOG=N > R=littledan@chromium.org > > Committed: https://crrev.com/fa9c39eeadd8e692af03b024fe2fdcf94ad0da6b > Cr-Commit-Position: refs/heads/master@{#31971} TBR=caitpotter88@gmail.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4360 Committed: https://crrev.com/70177a817c2ea81e0c165c4b1f3b674a482554d7 Cr-Commit-Position: refs/heads/master@{#32189}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -28 lines) Patch
M src/js/i18n.js View 3 chunks +39 lines, -28 lines 0 comments Download
M test/test262/test262.status View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dan Ehrenberg
Created Revert of [Intl] create new instances when new.target is undefined
5 years ago (2015-11-24 01:54:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1473493003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1473493003/1
5 years ago (2015-11-24 01:54:40 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 01:54:49 UTC) #3
commit-bot: I haz the power
5 years ago (2015-11-24 01:55:07 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/70177a817c2ea81e0c165c4b1f3b674a482554d7
Cr-Commit-Position: refs/heads/master@{#32189}

Powered by Google App Engine
This is Rietveld 408576698