Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1473483002: Fix really dumb mistake in Mac accessibility. (Closed)

Created:
5 years, 1 month ago by dmazzoni
Modified:
5 years, 1 month ago
Reviewers:
aboxhall
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix really dumb mistake in Mac accessibility. Missing braces when adding code inside an "if" block, resulting in lots of attributes being marked as editable when they shouldn't be, breaking VoiceOver. Regression happened in: https://crrev.com/6185ca046850b24b92a5dffd9ab7d1ecc3048001 https://codereview.chromium.org/1435113003/ BUG=559210, 473220 Committed: https://crrev.com/a9a175a4c93023a84d52814c973520d15617dbe6 Cr-Commit-Position: refs/heads/master@{#361235}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M content/browser/accessibility/browser_accessibility_cocoa.mm View 1 chunk +3 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
dmazzoni
5 years, 1 month ago (2015-11-23 23:36:46 UTC) #2
aboxhall
lgtm
5 years, 1 month ago (2015-11-24 00:37:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1473483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1473483002/1
5 years, 1 month ago (2015-11-24 00:43:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-24 02:29:15 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-24 02:30:44 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a9a175a4c93023a84d52814c973520d15617dbe6
Cr-Commit-Position: refs/heads/master@{#361235}

Powered by Google App Engine
This is Rietveld 408576698