Issue 1473413002: EDK: Add a TestIOThread::IsCurrentAndRunning().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1473413002: EDK: Add a TestIOThread::IsCurrentAndRunning(). (Closed)

Created:
5 years ago by viettrungluu

Modified:
5 years ago

Reviewers:
vardhan

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

EDK: Add a TestIOThread::IsCurrentAndRunning(). (In many places in tests, we simply want to verify that we're on the test I/O thread.) R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/abe8f82337ef90fed55efd3f7533753ed154604d

Patch Set 1 #

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -20 lines)			Patch
M	mojo/edk/system/channel_test_base.cc	View	4 chunks	+4 lines, -5 lines	0 comments	Download
M	mojo/edk/system/data_pipe_impl_unittest.cc	View	3 chunks	+2 lines, -3 lines	0 comments	Download
M	mojo/edk/system/message_pipe_test_utils.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/edk/system/remote_data_pipe_impl_unittest.cc	View	3 chunks	+2 lines, -3 lines	0 comments	Download
M	mojo/edk/system/remote_message_pipe_unittest.cc	View	7 chunks	+6 lines, -7 lines	0 comments	Download
M	mojo/edk/system/test/test_io_thread.h	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	mojo/edk/system/test/test_io_thread.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

5 years ago (2015-11-24 22:18:21 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
abe8f82337ef90fed55efd3f7533753ed154604d (presubmit successful).

Expand Messages | Collapse Messages