runtime/vm/parser.cc - Issue 1473403003: Move ApiLocalScope out of class ApiState into class Thread so that the API local handles and zone e…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/parser.cc

Issue 1473403003: Move ApiLocalScope out of class ApiState into class Thread so that the API local handles and zone e… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: code-review-patch Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/parser.cc

diff --git a/runtime/vm/parser.cc b/runtime/vm/parser.cc

index 26f2ad7adb095eb5f22a4e1473c56684e15d4ad5..077a504891014b52adf06375346e4f0153f633e7 100644

--- a/runtime/vm/parser.cc

+++ b/runtime/vm/parser.cc

@@ -5823,8 +5823,8 @@ RawObject* Parser::CallLibraryTagHandler(Dart_LibraryTag tag,

I->BlockClassFinalization();

Api::Scope api_scope(T);

Dart_Handle result = handler(tag,

- Api::NewHandle(I, library_.raw()),

- Api::NewHandle(I, url.raw()));

+ Api::NewHandle(T, library_.raw()),

+ Api::NewHandle(T, url.raw()));

I->UnblockClassFinalization();

if (Dart_IsError(result)) {

// In case of an error we append an explanatory error message to the

« no previous file with comments | « runtime/vm/object_id_ring_test.cc ('k') | runtime/vm/service_test.cc » ('j') | no next file with comments »