Move ApiLocalScope out of class ApiState into class Thread so that the API local handles and zone e…

runtime/vm/thread_registry.h

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_THREAD_REGISTRY_H_
 #define VM_THREAD_REGISTRY_H_
 
 #include "vm/globals.h"
 #include "vm/growable_array.h"
 #include "vm/isolate.h"
@@ skipping 55 matching lines @@
 
   // Returns the number threads that are scheduled on this isolate.
   // Note: Lock should be taken before this function is called.
   intptr_t CountScheduledLocked();
 
   Monitor* monitor_;  // All access is synchronized through this monitor.
   Thread* active_list_;  // List of active threads in the isolate.
   Thread* free_list_;  // Free list of Thread objects that can be reused.
   // TODO(asiva): Currently we treat a mutator thread as a special thread
   // and always schedule execution of Dart code on the same mutator thread
-  // object. This is because ApiState is still an object associated with
-  // the isolate and switching execution to another thread causes problems.
-  // Once ApiState is made a per Thread object it should be possible to
-  // free a mutator thread like all other threads and continue running on
-  // a different thread.
+  // object. The ApiLocalScope has been made thread specific but we still
+  // have scenarios where we do a temporary exit of an Isolate with live
+  // zones/handles in the the API scope :
+  // - Dart_RunLoop()
+  // - IsolateSaver in Dart_NewNativePort
+  // - Isolate spawn (function/uri) under FLAG_i_like_slow_isolate_spawn
+  // We probably need a mechanism to return to the specific thread only
+  // for these specific cases, we should also determine if we should allow

[zra, 2015/11/25 17:36:56]

cases. We

[siva, 2015/11/25 18:25:08]

Done.

+  // the embedder to exit an isolate with live state in zones/handles in
+  // which case a new API for returning to the specific thread needs to be
+  // added.
   Thread* mutator_thread_;
 
   // Safepoint rendezvous state.
   bool in_rendezvous_;    // A safepoint rendezvous request is in progress.
   intptr_t remaining_;    // Number of threads yet to reach their safepoint.
   int64_t round_;         // Counter, to prevent missing updates to remaining_
                           // (see comments in CheckSafepointLocked).
 
   DISALLOW_COPY_AND_ASSIGN(ThreadRegistry);
 };
 
 }  // namespace dart
 
 #endif  // VM_THREAD_REGISTRY_H_