Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7219)

Unified Diff: chrome/browser/ui/website_settings/chooser_bubble_delegate.h

Issue 1473393003: Add chooser permission UI code for Mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@wpu_1
Patch Set: merged changes from master to fix merge conflicts Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/website_settings/chooser_bubble_delegate.h
diff --git a/chrome/browser/ui/website_settings/chooser_bubble_delegate.h b/chrome/browser/ui/website_settings/chooser_bubble_delegate.h
index d93161765d6777995a1f1228e79be27ec70b969f..038e989397fbb5b3648b1e959eb70a852d64284f 100644
--- a/chrome/browser/ui/website_settings/chooser_bubble_delegate.h
+++ b/chrome/browser/ui/website_settings/chooser_bubble_delegate.h
@@ -6,10 +6,10 @@
#define CHROME_BROWSER_UI_WEBSITE_SETTINGS_CHOOSER_BUBBLE_DELEGATE_H_
#include "base/macros.h"
-#include "chrome/browser/ui/website_settings/chooser_options.h"
#include "components/bubble/bubble_delegate.h"
-class ChooserBubbleUiView;
+class Browser;
+class ChooserOptions;
class ChooserBubbleDelegate : public BubbleDelegate {
public:
@@ -18,11 +18,18 @@ class ChooserBubbleDelegate : public BubbleDelegate {
// BubbleDelegate:
std::string GetName() const override;
+ scoped_ptr<BubbleUi> BuildBubbleUi() override;
+
+ static scoped_ptr<BubbleUi> CreateBubbleUi(
+ Browser* browser,
+ ChooserOptions* chooser_options,
+ ChooserBubbleDelegate* chooser_bubble_delegate);
virtual void Select(int index) = 0;
virtual void Cancel() = 0;
protected:
+ Browser* browser_;
Reilly Grant (use Gerrit) 2015/12/02 19:25:53 Require subclasses to pass this to the constructor
juncai 2015/12/03 05:19:08 Done.
scoped_ptr<ChooserOptions> chooser_options_;
private:

Powered by Google App Engine
This is Rietveld 408576698