chrome/browser/ui/website_settings/chooser_bubble_delegate.cc - Issue 1473393003: Add chooser permission UI code for Mac

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/website_settings/chooser_bubble_delegate.cc

Issue 1473393003: Add chooser permission UI code for Mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@wpu_1

Patch Set: merged changes from master to fix merge conflicts Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/website_settings/chooser_bubble_delegate.h ('K') | « chrome/browser/ui/website_settings/chooser_bubble_delegate.h ('k') | chrome/browser/usb/usb_chooser_bubble_delegate.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/website_settings/chooser_bubble_delegate.h"	5 #include "chrome/browser/ui/website_settings/chooser_bubble_delegate.h"

6	6

	7 #include "chrome/browser/ui/website_settings/chooser_options.h"

	8 #include "components/bubble/bubble_ui.h"

	9

7 ChooserBubbleDelegate::ChooserBubbleDelegate() {}	10 ChooserBubbleDelegate::ChooserBubbleDelegate() {}

8	11

9 ChooserBubbleDelegate::~ChooserBubbleDelegate() {}	12 ChooserBubbleDelegate::~ChooserBubbleDelegate() {}

10	13

11 std::string ChooserBubbleDelegate::GetName() const {	14 std::string ChooserBubbleDelegate::GetName() const {

12 return "ChooserBubble";	15 return "ChooserBubble";

13 }	16 }

	17

	18 scoped_ptr<BubbleUi> ChooserBubbleDelegate::BuildBubbleUi() {

	19 scoped_ptr<BubbleUi> bubble_ui =

	20 CreateBubbleUi(browser_, chooser_options_.get(), this);

	21 return bubble_ui.Pass();
	Reilly Grant (use Gerrit) 2015/12/02 19:25:53 No need for a local, just: return CreateBubbleUi( No need for a local, just: return CreateBubbleUi(browser_, chooser_options_.get(), this); juncai 2015/12/03 05:19:08 Done. Show quoted text On 2015/12/02 19:25:53, Reilly Grant wrote: > No need for a local, just: > > return CreateBubbleUi(browser_, chooser_options_.get(), this); Done.
	22 }

OLD	NEW