chrome/browser/ui/views/website_settings/chooser_bubble_ui_view_creator.cc - Issue 1473393003: Add chooser permission UI code for Mac

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/views/website_settings/chooser_bubble_ui_view_creator.cc

Issue 1473393003: Add chooser permission UI code for Mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@wpu_1

Patch Set: merged changes from master to fix merge conflicts Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "chrome/browser/ui/website_settings/chooser_bubble_delegate.h"

	6

	7 #include "chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.h"

	8

	9 // static

	10 scoped_ptr<BubbleUi> ChooserBubbleDelegate::CreateBubbleUi(
	Reilly Grant (use Gerrit) 2015/12/02 19:25:53 No need to put these in separate files. Just imple No need to put these in separate files. Just implement ChooserBubbleDelegate::BuildBubbleUi in chooser_bubble_ui_view.cc and chooser_bubble_ui_cocoa.mm. juncai 2015/12/03 05:19:08 Done. Show quoted text On 2015/12/02 19:25:53, Reilly Grant wrote: > No need to put these in separate files. Just implement > ChooserBubbleDelegate::BuildBubbleUi in chooser_bubble_ui_view.cc and > chooser_bubble_ui_cocoa.mm. Done.
	11 Browser* browser,

	12 ChooserOptions* chooser_options,

	13 ChooserBubbleDelegate* chooser_bubble_delegate) {

	14 scoped_ptr<BubbleUi> bubble_ui(new ChooserBubbleUiView(

	15 browser, chooser_options, chooser_bubble_delegate));

	16 return bubble_ui.Pass();

	17 }

OLD	NEW