chrome/browser/ui/website_settings/chooser_bubble_delegate.cc - Issue 1473393003: Add chooser permission UI code for Mac

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/website_settings/chooser_bubble_delegate.cc

Issue 1473393003: Add chooser permission UI code for Mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@wpu_1

Patch Set: address reillyg@'s comments Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/website_settings/chooser_bubble_delegate.h"	5 #include "chrome/browser/ui/website_settings/chooser_bubble_delegate.h"

6	6

7 ChooserBubbleDelegate::ChooserBubbleDelegate() {}	7 #include "base/logging.h"

	8

	9 ChooserBubbleDelegate::ChooserBubbleDelegate(Browser* browser)

	10 : browser_(browser) {

	11 DCHECK(browser_);
	felt 2015/12/10 02:17:24 suggestion: move this DCHECK closer to where \|brow suggestion: move this DCHECK closer to where \|browser\| is used juncai 2015/12/10 20:44:09 Done. Show quoted text On 2015/12/10 02:17:24, felt wrote: > suggestion: move this DCHECK closer to where \|browser\| is used Done.
	12 }

8	13

9 ChooserBubbleDelegate::~ChooserBubbleDelegate() {}	14 ChooserBubbleDelegate::~ChooserBubbleDelegate() {}

10	15

11 std::string ChooserBubbleDelegate::GetName() const {	16 std::string ChooserBubbleDelegate::GetName() const {

12 return "ChooserBubble";	17 return "ChooserBubble";

13 }	18 }

OLD	NEW