optimize the disable-caching case for SkImage::readPixels

src/core/SkImageCacherator.h

Index: src/core/SkImageCacherator.h
diff --git a/src/core/SkImageCacherator.h b/src/core/SkImageCacherator.h
index 5ba5422181fb332c27bdd753c1097450eca54023..bce39679c628e15211b1240f6715b9d5506a85c6 100644
--- a/src/core/SkImageCacherator.h
+++ b/src/core/SkImageCacherator.h
@@ -57,6 +57,12 @@ public:
      */
     SkData* refEncoded();
 
+    // Only return true if the generate has already been cached.
+    bool lockAsBitmapOnlyIfAlreadyCached(SkBitmap*);
+    // Call the underlying generator directly
+    bool directGeneratePixels(const SkImageInfo& dstInfo, void* dstPixels, size_t dstRB,

[f(malita), 2015/11/24 19:36:07]

I guess this matches existing internal APIs, but would it make sense to switch
to SkPixmap at some point?

[reed1, 2015/11/24 19:43:49]

Yep. Would probably start with SkImageGenerator, and move our way up. I propose
we tackle that separately (thank goodness this header is private).

+                              int srcX, int srcY);
+
 private:
     SkImageCacherator(SkImageGenerator*, const SkImageInfo&, const SkIPoint&, uint32_t uniqueID);