third_party/WebKit/Source/core/dom/FirstLetterPseudoElement.cpp - Issue 1473363003: Invalidate first line display item clients when first line style changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/FirstLetterPseudoElement.cpp

Issue 1473363003: Invalidate first line display item clients when first line style changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Source/core/paint/README.md Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css/first-line-hover-001.html ('k') | third_party/WebKit/Source/core/layout/LayoutBlock.h » ('j') | third_party/WebKit/Source/core/layout/LayoutBlock.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/FirstLetterPseudoElement.cpp

diff --git a/third_party/WebKit/Source/core/dom/FirstLetterPseudoElement.cpp b/third_party/WebKit/Source/core/dom/FirstLetterPseudoElement.cpp

index b9211d581c3ad56c6a8bcefef99d9b227ffe3e39..1b8e5efdd3932d7e15646392139d182b8723f3ad 100644

--- a/third_party/WebKit/Source/core/dom/FirstLetterPseudoElement.cpp

+++ b/third_party/WebKit/Source/core/dom/FirstLetterPseudoElement.cpp

@@ -109,7 +109,7 @@ LayoutObject* FirstLetterPseudoElement::firstLetterTextLayoutObject(const Elemen

if (!parentLayoutObject

|| !parentLayoutObject->style()->hasPseudoStyle(FIRST_LETTER)

|| !canHaveGeneratedChildren(*parentLayoutObject)

- || !(parentLayoutObject->isLayoutBlockFlow() || parentLayoutObject->isLayoutButton()))

+ || !parentLayoutObject->canHaveFirstLineOrFirstLetterStyle())

return nullptr;

// Drill down into our children and look for our first text child.