third_party/WebKit/Source/core/layout/LayoutBlockFlow.h - Issue 1473363003: Invalidate first line display item clients when first line style changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlockFlow.h

Issue 1473363003: Invalidate first line display item clients when first line style changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address mstensho's comments Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/css/button-first-line-change-color.html ('K') | « third_party/WebKit/Source/core/layout/LayoutBlock.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp » ('j') | third_party/WebKit/Source/core/layout/LayoutObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutBlockFlow.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.h b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.h

index 36120f88132fdee680e2e0503d304d5bf7f3d547..848a7109e1bc1b4135026c41f9a04c7db23ed71b 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.h

+++ b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.h

@@ -292,6 +292,8 @@ public:

return containsFloats() ? m_floatingObjects->set().last().get() : nullptr;

}

+ void invalidateDisplayItemClientsOfFirstLine();

protected:

void rebuildFloatsFromIntruding();

void layoutInlineChildren(bool relayoutChildren, LayoutUnit& paintInvalidationLogicalTop, LayoutUnit& paintInvalidationLogicalBottom, LayoutUnit afterEdge);