Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 1473363003: Invalidate first line display item clients when first line style changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Handle inherited firstline style Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Element.cpp
diff --git a/third_party/WebKit/Source/core/dom/Element.cpp b/third_party/WebKit/Source/core/dom/Element.cpp
index e785c06dfc53d2423487e8af18cf389fe9095aa8..bfe6476ed60a517b55de336e312b86abf4a445ac 100644
--- a/third_party/WebKit/Source/core/dom/Element.cpp
+++ b/third_party/WebKit/Source/core/dom/Element.cpp
@@ -1791,7 +1791,8 @@ StyleRecalcChange Element::recalcOwnStyle(StyleRecalcChange change)
updateCallbackSelectors(oldStyle.get(), newStyle.get());
if (LayoutObject* layoutObject = this->layoutObject()) {
- if (localChange != NoChange || pseudoStyleCacheIsInvalid(oldStyle.get(), newStyle.get()) || svgFilterNeedsLayerUpdate()) {
+ bool pseudoStyleCacheIsInvalid = this->pseudoStyleCacheIsInvalid(oldStyle.get(), newStyle.get());
chrishtr 2015/12/01 01:43:11 this-> not necessary? Also, that pseudoStyleCache
Xianzhu 2015/12/01 20:06:25 Done.
+ if (localChange != NoChange || pseudoStyleCacheIsInvalid || svgFilterNeedsLayerUpdate()) {
layoutObject->setStyle(newStyle.get());
} else {
// Although no change occurred, we use the new style so that the cousin style sharing code won't get

Powered by Google App Engine
This is Rietveld 408576698