Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: third_party/WebKit/Source/core/layout/line/InlineBox.h

Issue 1473363003: Invalidate first line display item clients when first line style changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address mstensho's comments Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All r ights reserved. 2 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All r ights reserved.
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 282 matching lines...) Expand 10 before | Expand all | Expand 10 after
293 void flipForWritingMode(LayoutRect&) const; 293 void flipForWritingMode(LayoutRect&) const;
294 LayoutPoint flipForWritingMode(const LayoutPoint&) const; 294 LayoutPoint flipForWritingMode(const LayoutPoint&) const;
295 295
296 bool knownToHaveNoOverflow() const { return m_bitfields.knownToHaveNoOverflo w(); } 296 bool knownToHaveNoOverflow() const { return m_bitfields.knownToHaveNoOverflo w(); }
297 void clearKnownToHaveNoOverflow(); 297 void clearKnownToHaveNoOverflow();
298 298
299 bool dirOverride() const { return m_bitfields.dirOverride(); } 299 bool dirOverride() const { return m_bitfields.dirOverride(); }
300 void setDirOverride(bool dirOverride) { m_bitfields.setDirOverride(dirOverri de); } 300 void setDirOverride(bool dirOverride) { m_bitfields.setDirOverride(dirOverri de); }
301 301
302 DisplayItemClient displayItemClient() const { return toDisplayItemClient(thi s); } 302 DisplayItemClient displayItemClient() const { return toDisplayItemClient(thi s); }
303 void invalidateDisplayItemClientsRecursively();
chrishtr 2015/12/03 18:41:56 It's not super clear how far this recursion goes.
Xianzhu 2015/12/03 19:10:40 Acknowledged.
mstensho (USE GERRIT) 2015/12/03 19:58:02 Why this change now? I don't recall having seen an
Xianzhu 2015/12/03 20:34:55 I'm also working on crbug.com/563943 and found thi
mstensho (USE GERRIT) 2015/12/03 20:41:57 OK, fair enough. Then ignore me, but chrishtr has
Xianzhu 2015/12/03 22:47:05 Done.
303 304
304 #define ADD_BOOLEAN_BITFIELD(name, Name) \ 305 #define ADD_BOOLEAN_BITFIELD(name, Name) \
305 private:\ 306 private:\
306 unsigned m_##name : 1;\ 307 unsigned m_##name : 1;\
307 public:\ 308 public:\
308 bool name() const { return m_##name; }\ 309 bool name() const { return m_##name; }\
309 void set##Name(bool name) { m_##name = name; }\ 310 void set##Name(bool name) { m_##name = name; }\
310 311
311 class InlineBoxBitfields { 312 class InlineBoxBitfields {
312 DISALLOW_NEW(); 313 DISALLOW_NEW();
(...skipping 137 matching lines...) Expand 10 before | Expand all | Expand 10 after
450 451
451 } // namespace blink 452 } // namespace blink
452 453
453 #ifndef NDEBUG 454 #ifndef NDEBUG
454 // Outside the WebCore namespace for ease of invocation from gdb. 455 // Outside the WebCore namespace for ease of invocation from gdb.
455 void showTree(const blink::InlineBox*); 456 void showTree(const blink::InlineBox*);
456 void showLineTree(const blink::InlineBox*); 457 void showLineTree(const blink::InlineBox*);
457 #endif 458 #endif
458 459
459 #endif // InlineBox_h 460 #endif // InlineBox_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698